Fixes issue with value extraction from raw message#10
Open
asbjorn wants to merge 11 commits intotimmathews:masterfrom
Open
Fixes issue with value extraction from raw message#10asbjorn wants to merge 11 commits intotimmathews:masterfrom
asbjorn wants to merge 11 commits intotimmathews:masterfrom
Conversation
…s to change throughout the loop. To avoid runtime errors then this seems to work.
An additional check since the length of the PgnList[i].FieldList look…
Update from upstream
…umber. If value is too large (overflowed) the function `func (msg *RawMessage) extractNumber(..)` returns an error and the value will be set to nil.
…b.com/canboat/canboat
Contributor
Author
|
Hi @timmathews - did you get the time to look into this PR? |
Contributor
Author
|
@timmathews Any progress on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been debugging this issue as it causes a lot of strange values streaming from the CANbus (through Actisense NGT-1).
Periodically there seems to be corrupt values, so the process of verify the value based on a computed maximum value seems to be missing from this library. However, the analyzer program and the extraction functions from https://github.com/canboat/canboat/ seems to get it correct.
Therefore I've implemented a similar checking in this library as well. Provided a go testcase which checks the expected behavior.