[twarp upstream] typo & comment fixes#24
Merged
Conversation
## Description While reading through a few crates I kept noticing duplicated words in comments — "the the", "in in", "to to", "and and", "a a", "that that". A quick `grep` turned up 17 of them across 15 files. All edits are in `//` and `///` comments — no code, test, or behavior change. Files touched: - `crates/settings/src/manager.rs` - `crates/websocket/src/sink_map_err.rs` - `crates/warp_completer/src/completer/suggest/test.rs` - `crates/warp_completer/src/completer/engine/argument/legacy.rs` - `crates/warp_completer/src/completer/engine/argument/v2.rs` - `crates/warp_core/src/ui/color/contrast.rs` - `crates/warp_logging/src/wasm.rs` - `crates/warpui_core/src/core/app.rs` - `crates/warpui_core/src/elements/selectable_area.rs` - `crates/warpui_core/src/elements/flex/mod_test.rs` - `crates/warpui/src/platform/mac/text_layout_test.rs` - `crates/warpui/src/platform/mac/rendering/wgpu/mod.rs` - `crates/warpui/src/platform/app.rs` - `crates/warpui/src/windowing/winit/fonts/font_handle.rs` - `crates/warpui/src/fonts/text_layout_test.rs` Distinct from warpdotdev#9318, which sweeps single-word misspellings (Surpress, occassionally, etc.) under `app/`. I also skipped the two doubled-word lines in `crates/integration/src/test.rs` since warpdotdev#9279 is currently editing that file — happy to fold them in if that PR lands first. ## Testing Comments-only. --------- Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com> Co-authored-by: Aloke Desai <aloke.desai@gmail.com> Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
## Description Corrects a misspelling in the doc comment on `is_welcome_object` in `crates/warp_server_client/src/cloud_object/mod.rs`: `recieves` → `receives`. ## Testing Doc-comment-only change. Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com> Co-authored-by: Aloke Desai <aloke@warp.dev>
## Description Fixes a one-character typo in a comment in `crates/warpui_core/src/elements/stack/mod_test.rs` (line 453): `teh` -> `the`. Comment-only change with no functional or test impact; the previous line of the same comment block uses the correct spelling, so this is an obvious slip. ## Testing Comment-only change in a test file; no test impact. ## Agent Mode - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode Co-authored-by: BennyWaitWhat <BennyWaitWhat@users.noreply.github.com>
## Description Fixes a typo in the `process_emphasis` doc comment in `crates/markdown_parser/src/markdown_parser.rs`: `performace` → `performance`. ## Testing Doc-comment-only change. Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks 4 typo/comment-only fixes from
warpdotdev/warp.150df7e9165c771e938ad8443476f193All four picks landed cleanly with no conflicts.
Test plan