Skip to content

Move e2e to the trixie-slim CaptainOS artifacts: - #250

Merged
mergify[bot] merged 1 commit into
tinkerbell:mainfrom
jacobweinstock:captainos-trixie-slim
Oct 12, 2026
Merged

mergify[bot] merged 1 commit into
tinkerbell:mainfrom
jacobweinstock:captainos-trixie-slim

Conversation

@jacobweinstock

Copy link
Copy Markdown
Member

Description

CaptainOS artifacts are now named by flavor rather than kernel version, so the kernel, initrd and ISO names derived from captainos.kernelVersion no longer exist in the image and every boot would fail to fetch them.

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Netboot kernel and initramfs filenames omit the required architecture suffix and will fail to fetch.

1 open finding
What changed in this PR

Updates CAPT playground and e2e configuration for flavor-based CaptainOS artifacts.

Changes:

  • Replaces kernelVersion with flavor.
  • Pins the trixie-slim CaptainOS image.
  • Enables backend Kubernetes rendering.
File Description
capt/​tasks/​Taskfile-helm.yaml Builds flavor-based artifact paths.
capt/​e2e/​cue/​base.cue Updates e2e CaptainOS defaults.
capt/​cue/​values/​values.cue Updates state validation schema.
capt/​cue/​state/​state.cue Updates configuration input schema.
capt/​config.yaml Updates default CaptainOS configuration.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread capt/tasks/Taskfile-helm.yaml Outdated
CaptainOS artifacts are now named by flavor rather than kernel
version, so the kernel, initrd and ISO names derived from
captainos.kernelVersion no longer exist in the image and every
boot would fail to fetch them.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Hardware template rendering is enabled unconditionally despite being unrelated to artifact naming and potentially breaking literal template payloads.

1 open finding
1 resolved since last review

🧠 Review effort: Balanced

Comment thread capt/tasks/Taskfile-helm.yaml
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Oct 12, 2026
@mergify

mergify Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 minutes 1 second in the queue, including 1 minute 27 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Oct 12, 2026
@mergify mergify Bot mentioned this pull request Oct 12, 2026
30 of 40 tasks
@mergify
mergify Bot merged commit 24b29e9 into tinkerbell:main Oct 12, 2026
6 checks passed
@jacobweinstock
jacobweinstock deleted the captainos-trixie-slim branch October 12, 2026 21:25
@mergify mergify Bot removed the queued label Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Signal to Mergify to merge the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants