PR to allow shellCommand and containerLimit#12
Conversation
|
Just starting to test this. Two things:
Thanks for starting this! |
|
Yeah I was afraid that there was going to be an issue with that regex. I'll take a look around and see what I can come up with for a better way. Will also take a look at ElasticPress and see if I can get it working. |
|
Now that I have fixed rouster, I'll go back to this PR and fix it for ElasticPress. Any other projects you can point to that would be good to test with? |
|
And I see the issue, they have '' (two single quotes side by side) and the regex for command line parsing is looking for there to be at least something between them. Switching it to 0 or more seems to resolve this: Also had to add in some logic to remove those hard embedded 's and "s since they are put back in for you by the shell exec command when you use its array form. The code is a little dirty right now, but it works locally. Doing some more testing and then will update the PR. |
|
Code coverage is what is failing on the tests, still have to fix that :D |
|
Here is another test Dockunit file - https://github.com/tlovett1/custom-contact-forms/blob/master/Dockunit.json |
|
Cool, so with the latest changes I get the same results for the current codebase as I do the new code base that uses rouster and I can run it in parallel (limit 3) on all 3 test cases I have with no issues. |
This adds in support for shellCommand (for distros like Alpine that need a different shell command) and containerLimit to allow parallel execution of tests.
Ton's of refactor work in there. So much that I actually broke out the docker wrapper to its own npm module called rouster then re-wrapped everything back up into a nice package. Also brings in async to do some of the heavy lifting.
Lots of manual testing done, and I think I got the actual tests right, but there was so much refactor that some may still need to be re-written.
Also, version bump to 0.5.4 included.
Completely backward compatible.
Closes #4, #10, and #11