Skip to content

Fix Hermes build to use correct compilers on macOS #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoaoPauloCMarra wants to merge 1 commit into from
Closed

Fix Hermes build to use correct compilers on macOS #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmake/HermesExternal.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ else()
LOG_BUILD ON
LOG_OUTPUT_ON_FAILURE ON
UPDATE_DISCONNECTED ON
ENV CC ${CMAKE_C_COMPILER}
ENV CXX ${CMAKE_CXX_COMPILER}
Comment on lines +110 to +111
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ENV directive syntax is incorrect. Each ENV entry should be a single key=value pair on one line. The correct syntax should be ENV \"CC=${CMAKE_C_COMPILER}\" \"CXX=${CMAKE_CXX_COMPILER}\" or split into separate ENV directives like ENV CC=${CMAKE_C_COMPILER} and ENV CXX=${CMAKE_CXX_COMPILER}.

Suggested change
ENV CC ${CMAKE_C_COMPILER}
ENV CXX ${CMAKE_CXX_COMPILER}
ENV "CC=${CMAKE_C_COMPILER}" "CXX=${CMAKE_CXX_COMPILER}"

Copilot uses AI. Check for mistakes.
Comment on lines +110 to +111
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These environment variables appear redundant since CMAKE_C_COMPILER and CMAKE_CXX_COMPILER are already being passed via CMAKE_ARGS at lines 90-91. While setting both CMAKE_ARGS and ENV variables can help with multi-stage builds (configure vs build/link), consider documenting why both are necessary if this duplication is intentional.

Suggested change
ENV CC ${CMAKE_C_COMPILER}
ENV CXX ${CMAKE_CXX_COMPILER}

Copilot uses AI. Check for mistakes.
)

# Set tool paths (these will be valid after Hermes is built)
Expand Down