Skip to content

[Snyk] Security upgrade starlette from 0.27.0 to 0.49.1 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomkat-cr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade starlette from 0.27.0 to 0.49.1 #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gsam_ottomator_agent/base_python_docker/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ pydantic
supabase
python-dotenv
asyncpg
starlette>=0.49.1 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

@gemini-code-assist gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change is likely to break the build for the Docker image.

The fastapi package, which is included in this requirements.txt, has a strict dependency on starlette. For example, the latest public version of fastapi (0.111.0) requires starlette < 0.38.0, which conflicts with the >=0.49.1 constraint being added. This will cause pip to fail during dependency resolution.

The root cause is that dependencies in this file are not pinned, which can lead to unpredictable behavior. The Snyk warning about pydantic in the PR description is another symptom of this.

To fix this properly, you should:

  1. Pin all dependencies in this file to specific versions for reproducible builds. You can use the versions from the root requirements.txt as a starting point.
  2. Upgrade fastapi to a version that is compatible with starlette >= 0.49.1 to resolve the security vulnerability without breaking the build. Both fastapi and starlette versions should be pinned.

Since this automated PR doesn't account for the fastapi dependency, it needs manual intervention to resolve the conflict.