Skip to content

BinaryFileStorage writer #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

BinaryFileStorage writer #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9c0e6
Changes to use BinaryFileStorage
tonyredondo Jul 15, 2025
9fc56eb
improvements
tonyredondo Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>
<PropertyGroup>
<Version>0.4.1</Version>
<Version>0.4.2</Version>
<Authors>Tony Redondo, Grégory Léocadie</Authors>
<TargetFrameworks>net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down
70 changes: 38 additions & 32 deletions src/TimeItSharp.Common/ScenarioProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,16 @@
using System.Diagnostics.CodeAnalysis;
using System.Runtime.InteropServices;
using System.Text;
using System.Text.Json;
using System.Text.Json.Nodes;
using CliWrap;
using CliWrap.Buffered;
using DatadogTestLogger.Vendors.Datadog.Trace;
using MathNet.Numerics.Distributions;
using MathNet.Numerics.Statistics;
using Spectre.Console;
using TimeItSharp.Common.Assertors;
using TimeItSharp.Common.Configuration;
using TimeItSharp.Common.Results;
using TimeItSharp.Common.Services;
using TimeItSharp.RuntimeMetrics;
using Status = TimeItSharp.Common.Results.Status;

namespace TimeItSharp.Common;
Expand Down Expand Up @@ -794,29 +792,37 @@ private async Task<DataPoint> RunCommandAsync(int index, Scenario scenario, Time
var metrics = new Dictionary<string, double>();
var metricsCount = new Dictionary<string, int>();

Span<byte> bytesBuffer = stackalloc byte[1024];
foreach (var metricJsonItem in File.ReadLines(metricsFilePath))
await using (var file = File.Open(metricsFilePath, FileMode.Open, FileAccess.Read, FileShare.Read))
using (var reader = new BinaryReader(file))
{
try
while (file.Position < file.Length)
{
var bytesCount = Encoding.UTF8.GetBytes(metricJsonItem, bytesBuffer);
var metricsJsonItemBytes = bytesBuffer.Slice(0, bytesCount);
var jsonReader = new Utf8JsonReader(metricsJsonItemBytes);
if (JsonDocument.TryParseValue(ref jsonReader, out var jsonMetricsItem))
// Read magic number
if (reader.ReadInt32() != 7248)
{
var jsonRoot = jsonMetricsItem.RootElement;
var type = jsonRoot.GetProperty("type").GetString();
var name = jsonRoot.GetProperty("name").GetString();
var value = jsonRoot.GetProperty("value").GetDouble();
continue;
}

// Read metric type
var type = (BinaryFileStorage.MetricType)reader.ReadByte();
// Read name length
var nameLength = reader.ReadInt32();
// Read name
var nameBytes = reader.ReadBytes(nameLength);
var name = Encoding.UTF8.GetString(nameBytes);
// Read value
var value = reader.ReadDouble();

try
{
if (name is not null)
{
static void EnsureMainDuration(Dictionary<string, double> values,
DateTime? mainStartDate, DateTime? mainEndDate)
{
if (mainStartDate is not null && mainEndDate is not null)
{
values[Constants.ProcessInternalDurationMetricName] =
values[Constants.ProcessInternalDurationMetricNameString] =
(mainEndDate.Value - mainStartDate.Value).TotalMilliseconds;
}
}
Expand All @@ -838,59 +844,59 @@ mainEndDate is not null &&
var internalDuration = (endDate.Value - startDate.Value).TotalMilliseconds;
var overheadDuration = internalDuration - mainDuration;
var globalDuration = (point.End - point.Start).TotalMilliseconds;
values[Constants.ProcessStartupHookOverheadMetricName] = overheadDuration;
values[Constants.ProcessCorrectedDurationMetricName] =
values[Constants.ProcessStartupHookOverheadMetricNameString] = overheadDuration;
values[Constants.ProcessCorrectedDurationMetricNameString] =
globalDuration - overheadDuration;
}
}

if (name == Constants.ProcessStartTimeUtcMetricName)
if (name == Constants.ProcessStartTimeUtcMetricNameString)
{
inProcStartDate = DateTime.FromBinary((long)value);
metrics[Constants.ProcessTimeToStartMetricName] =
metrics[Constants.ProcessTimeToStartMetricNameString] =
(inProcStartDate.Value - dataPoint.Start).TotalMilliseconds;
EnsureStartupHookOverhead(dataPoint, metrics, inProcStartDate, inProcMainStartDate,
inProcMainEndDate, inProcEndDate);
continue;
}

if (name == Constants.MainMethodStartTimeUtcMetricName)
if (name == Constants.MainMethodStartTimeUtcMetricNameString)
{
inProcMainStartDate = DateTime.FromBinary((long)value);
metrics[Constants.ProcessTimeToMainMetricName] =
metrics[Constants.ProcessTimeToMainMetricNameString] =
(inProcMainStartDate.Value - dataPoint.Start).TotalMilliseconds;
EnsureMainDuration(metrics, inProcMainStartDate, inProcMainEndDate);
EnsureStartupHookOverhead(dataPoint, metrics, inProcStartDate, inProcMainStartDate,
inProcMainEndDate, inProcEndDate);
continue;
}

if (name == Constants.MainMethodEndTimeUtcMetricName)
if (name == Constants.MainMethodEndTimeUtcMetricNameString)
{
inProcMainEndDate = DateTime.FromBinary((long)value);
metrics[Constants.ProcessTimeToMainEndMetricName] =
metrics[Constants.ProcessTimeToMainEndMetricNameString] =
(dataPoint.End - inProcMainEndDate.Value).TotalMilliseconds;
EnsureMainDuration(metrics, inProcMainStartDate, inProcMainEndDate);
EnsureStartupHookOverhead(dataPoint, metrics, inProcStartDate, inProcMainStartDate,
inProcMainEndDate, inProcEndDate);
continue;
}

if (name == Constants.ProcessEndTimeUtcMetricName)
if (name == Constants.ProcessEndTimeUtcMetricNameString)
{
inProcEndDate = DateTime.FromBinary((long)value);
metrics[Constants.ProcessTimeToEndMetricName] =
metrics[Constants.ProcessTimeToEndMetricNameString] =
(dataPoint.End - inProcEndDate.Value).TotalMilliseconds;
EnsureStartupHookOverhead(dataPoint, metrics, inProcStartDate, inProcMainStartDate,
inProcMainEndDate, inProcEndDate);
continue;
}

if (type == "counter")
if (type == BinaryFileStorage.MetricType.Counter)
{
metrics[name] = value;
}
else if (type is "gauge" or "timer")
else if (type is BinaryFileStorage.MetricType.Gauge or BinaryFileStorage.MetricType.Timer)
{
ref var oldValue = ref CollectionsMarshal.GetValueRefOrAddDefault(metrics, name, out _);
oldValue += value;
Expand All @@ -899,17 +905,17 @@ mainEndDate is not null &&
ref CollectionsMarshal.GetValueRefOrAddDefault(metricsCount, name, out _);
count++;
}
else if (type == "increment")
else if (type == BinaryFileStorage.MetricType.Increment)
{
ref var oldValue = ref CollectionsMarshal.GetValueRefOrAddDefault(metrics, name, out _);
oldValue += value;
}
}
}
}
catch
{
// Error reading metric item, we just skip that item
catch
{
// Error reading metric item, we just skip that item
}
}
}

Expand Down
35 changes: 24 additions & 11 deletions src/TimeItSharp.StartupHook/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,28 @@ internal static class Constants
public const string StartupHookEnvironmentVariable = "DOTNET_STARTUP_HOOKS";
public const string TimeItMetricsTemporalPathEnvironmentVariable = "TIMEIT_METRICS_TEMPORAL_PATH";
public const string TimeItMetricsProcessName = "TIMEIT_METRICS_PROCESS_NAME";
public const string ProcessTimeToStartMetricName = "process.time_to_start_ms";
public const string ProcessTimeToMainMetricName = "process.time_to_main_ms";
public const string ProcessTimeToEndMetricName = "process.time_to_end_ms";
public const string ProcessTimeToMainEndMetricName = "process.time_to_end_main_ms";
public const string ProcessInternalDurationMetricName = "process.internal_duration_ms";
public const string ProcessCorrectedDurationMetricName = "process.corrected_duration_ms";
public const string ProcessStartupHookOverheadMetricName = "process.startuphook_overhead_ms";
public const string ProcessStartTimeUtcMetricName = "process.start";
public const string MainMethodStartTimeUtcMetricName = "main.start";
public const string MainMethodEndTimeUtcMetricName = "main.end";
public const string ProcessEndTimeUtcMetricName = "process.end";

public const string ProcessTimeToStartMetricNameString = "process.time_to_start_ms";
public const string ProcessTimeToMainMetricNameString = "process.time_to_main_ms";
public const string ProcessTimeToEndMetricNameString = "process.time_to_end_ms";
public const string ProcessTimeToMainEndMetricNameString = "process.time_to_end_main_ms";
public const string ProcessInternalDurationMetricNameString = "process.internal_duration_ms";
public const string ProcessCorrectedDurationMetricNameString = "process.corrected_duration_ms";
public const string ProcessStartupHookOverheadMetricNameString = "process.startuphook_overhead_ms";
public const string ProcessStartTimeUtcMetricNameString = "process.start";
public const string MainMethodStartTimeUtcMetricNameString = "main.start";
public const string MainMethodEndTimeUtcMetricNameString = "main.end";
public const string ProcessEndTimeUtcMetricNameString = "process.end";

public static ReadOnlySpan<byte> ProcessTimeToStartMetricName => "process.time_to_start_ms"u8;
public static ReadOnlySpan<byte> ProcessTimeToMainMetricName => "process.time_to_main_ms"u8;
public static ReadOnlySpan<byte> ProcessTimeToEndMetricName => "process.time_to_end_ms"u8;
public static ReadOnlySpan<byte> ProcessTimeToMainEndMetricName => "process.time_to_end_main_ms"u8;
public static ReadOnlySpan<byte> ProcessInternalDurationMetricName => "process.internal_duration_ms"u8;
public static ReadOnlySpan<byte> ProcessCorrectedDurationMetricName => "process.corrected_duration_ms"u8;
public static ReadOnlySpan<byte> ProcessStartupHookOverheadMetricName => "process.startuphook_overhead_ms"u8;
public static ReadOnlySpan<byte> ProcessStartTimeUtcMetricName => "process.start"u8;
public static ReadOnlySpan<byte> MainMethodStartTimeUtcMetricName => "main.start"u8;
public static ReadOnlySpan<byte> MainMethodEndTimeUtcMetricName => "main.end"u8;
public static ReadOnlySpan<byte> ProcessEndTimeUtcMetricName => "process.end"u8;
}
61 changes: 61 additions & 0 deletions src/TimeItSharp.StartupHook/RuntimeMetrics/BinaryFileStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
using System.Runtime.CompilerServices;

namespace TimeItSharp.RuntimeMetrics;

internal sealed class BinaryFileStorage(string filePath)
{
private readonly BinaryWriter _binaryWriter = new(new FileStream(filePath, FileMode.Append));

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Counter(ReadOnlySpan<byte> name, double value)
{
WritePayload(MetricType.Counter, name, value);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Gauge(ReadOnlySpan<byte> name, double value)
{
WritePayload(MetricType.Gauge, name, value);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Increment(ReadOnlySpan<byte> name, double value)
{
WritePayload(MetricType.Increment, name, value);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void Timer(ReadOnlySpan<byte> name, double value)
{
WritePayload(MetricType.Timer, name, value);
}

public void Dispose()
{
lock (_binaryWriter)
{
_binaryWriter.Dispose();
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private void WritePayload(MetricType type, ReadOnlySpan<byte> name, double value)
{
lock (_binaryWriter)
{
_binaryWriter.Write((int)7248); // Magic number for identification
_binaryWriter.Write((byte)type); // Metric type
_binaryWriter.Write(name.Length); // Length of the name
_binaryWriter.Write(name); // Name of the metric
_binaryWriter.Write(value); // Value of the metric
}
}

internal enum MetricType : byte
{
Counter,
Gauge,
Increment,
Timer
}
}
73 changes: 0 additions & 73 deletions src/TimeItSharp.StartupHook/RuntimeMetrics/FileStorage.cs
View file
Open in desktop

This file was deleted.

Loading
Loading