-
Notifications
You must be signed in to change notification settings - Fork 0
Add cli command for canonicalize oas document #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli command for canonicalize oas document #10
Conversation
Summary of ChangesHello @toothlessdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 풀 리퀘스트는 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Test Results61 tests 61 ✅ 0s ⏱️ Results for commit 2857a1d. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 patchlogr CLI에 OpenAPI 문서를 표준화하는 canonicalize 명령어를 추가합니다. 전반적으로 좋은 방향의 변경이지만, 몇 가지 중요한 수정이 필요합니다.
주요 피드백:
cli.ts에서 파일 경로를OpenAPI.Document객체로 파싱하지 않고runCanonicalize함수에 전달하여 발생하는 치명적인(critical) 타입 오류가 있습니다.runCanonicalize.ts에서 파일 쓰기 실패 시 오류를 제대로 전파하지 않아 명령어가 성공한 것처럼 보이는 심각한(high) 문제가 있습니다.- 오류 로깅 방식이 사용자에게 너무 장황할 수 있어 개선이 필요합니다.
자세한 내용은 각 파일에 대한 개별 코멘트를 참고해주세요.
📎 Related issues
📦 Scope
📌 Summary
✅ Checklist