Skip to content

Conversation

@toothlessdev
Copy link
Owner

📎 Related issues

📦 Scope

  • @patchlogr/core
  • @patchlogr/cli
  • @patchlogr/inspector
  • @patchlogr/oas
  • @patchlogr/types
  • docs, examples
  • tests
  • ci / cd / infra
  • other (아래에 명시)

📌 Summary

  • tsconfig 빌드 target, module resolution 설정 통일 및 일관성에 어긋나는 부분 수정
  • esbuild 및 package json 빌드 스크립트 작성
  • 배럴파일 규칙 통일

🧠 Context

  • target es2022 (node20+ 타깃으로 설정), lib es2022
  • module : nodenext (esm, cjs compat 한 node 타깃으로 설정)
  • moduleResolution : nodenext (module 과 통일)
  • esModuleInterop, allowSyntheticDefaultImports, resolveJsonModule 설정으로 json 모듈 및 esm 에서 cjs 의 default import 를 허용하도록 설정

⚠️ Impact

  • No Breaking Changes
  • Breaking Change
  • Versioning 영향 있음 (major / minor / patch)
  • 내부 리팩토링만 포함

✅ Checklist

  • 요구사항 명세 충족
  • 테스트 추가 / 수정
  • deterministic output 확인

@toothlessdev toothlessdev self-assigned this Jan 12, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @toothlessdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's build infrastructure by integrating esbuild for improved performance and standardizing TypeScript configurations across various packages. It also lays the groundwork for a new command-line interface, enhancing the project's utility and maintainability. These changes aim to create a more robust and efficient development environment.

Highlights

  • Build System Migration: Implemented esbuild for packages/patchlogr-cli and packages/patchlogr-oas to streamline the build process, enabling faster compilation and bundling.
  • TypeScript Configuration Standardization: Unified tsconfig settings across packages, setting target and lib to ES2022 and module and moduleResolution to NodeNext for consistent Node.js 20+ compatibility.
  • CLI Tool Introduction: Introduced a new command-line interface (patchlogr) within packages/patchlogr-cli using commander.js, including an initial canonicalize command for OpenAPI specifications.
  • ESLint Rule Enhancement: Added a new ESLint rule (@typescript-eslint/consistent-type-imports) to enforce consistent type import syntax, improving code quality and readability.
  • Package Refactoring: Refactored packages/patchlogr-oas to improve its internal structure by extracting preprocessOASDocument into its own file and using a barrel file for exports.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

Test Results

61 tests   61 ✅  0s ⏱️
13 suites   0 💤
 3 files     0 ❌

Results for commit 42d85a0.

♻️ This comment has been updated with latest results.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 esbuild를 사용하여 패키지를 빌드하고 CLI 구조를 도입하는 중요한 단계입니다. tsconfigpackage.json 파일에 대한 변경 사항은 일관성을 향상시켜주어 훌륭합니다. 새로 구현된 CLI와 관련하여 몇 가지 문제를 발견했으며, 여기에는 비동기 작업 처리의 심각한 버그와 타입 안정성 및 코드 명확성 개선 기회가 포함됩니다. 자세한 내용은 제 의견을 참조해주세요.

@toothlessdev toothlessdev merged commit da19a60 into develop Jan 12, 2026
3 checks passed
@toothlessdev toothlessdev deleted the 7-setup-esbuild-build-script branch January 12, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup esbuild build script

2 participants