-
Notifications
You must be signed in to change notification settings - Fork 0
Setup esbuild build script #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @toothlessdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's build infrastructure by integrating Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Test Results61 tests 61 ✅ 0s ⏱️ Results for commit 42d85a0. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 esbuild를 사용하여 패키지를 빌드하고 CLI 구조를 도입하는 중요한 단계입니다. tsconfig 및 package.json 파일에 대한 변경 사항은 일관성을 향상시켜주어 훌륭합니다. 새로 구현된 CLI와 관련하여 몇 가지 문제를 발견했으며, 여기에는 비동기 작업 처리의 심각한 버그와 타입 안정성 및 코드 명확성 개선 기회가 포함됩니다. 자세한 내용은 제 의견을 참조해주세요.
📎 Related issues
📦 Scope
📌 Summary
🧠 Context
✅ Checklist