PM-3906 ai review escalation by vas3a · Pull Request #1535 · topcoder-platform/platform-ui

vas3a · 2026-03-14T06:18:55Z

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-3906

What's in this PR?

Related PR: topcoder-platform/review-api-v6#226

…M-3926_ai-screening-phase

…M-3906_ai-review-escalation

src/apps/review/src/lib/components/TableReview/EscalationModals.tsx

github-actions · 2026-03-14T06:19:17Z

src/apps/review/src/lib/components/TableReview/TableReview.module.scss

        }
    }
+
+    :global(.TableCell) {


[⚠️ maintainability]
Using :global(.TableCell) for styling might lead to unintended side effects if .TableCell is used elsewhere in the application. Consider scoping this style more narrowly if possible.

github-actions · 2026-03-14T06:19:17Z

src/apps/review/src/lib/components/TableReview/TableReview.module.scss


+.statusLocked {
+    @extend .resultPill;
+    background-color: $black-5;


[⚠️ accessibility]
Ensure that $black-5 and $red-100 provide sufficient contrast for accessibility. Consider using a tool to verify color contrast ratios.

github-actions · 2026-03-14T06:19:17Z

src/apps/review/src/lib/components/TableReview/TableReview.module.scss

+.statusLocked {
+    @extend .resultPill;
+    background-color: $black-5;
+    color: $red-100;


[⚠️ accessibility]
Ensure that $red-100 provides sufficient contrast against $black-5 for accessibility. Consider using a tool to verify color contrast ratios.

github-actions · 2026-03-14T06:19:17Z

src/apps/review/src/lib/components/TableReview/TableReview.module.scss

 }

+.resultPending {
+    @extend .resultPill;


[⚠️ accessibility]
Ensure that $yellow-25 and $yellow-140 provide sufficient contrast for accessibility. Consider using a tool to verify color contrast ratios.

github-actions · 2026-03-14T06:19:17Z

src/apps/review/src/lib/components/TableReview/TableReview.module.scss


+.resultPending {
+    @extend .resultPill;
+    background-color: $yellow-25;


[⚠️ accessibility]
Ensure that $yellow-140 provides sufficient contrast against $yellow-25 for accessibility. Consider using a tool to verify color contrast ratios.

src/apps/review/src/lib/components/TableReview/TableReview.tsx

github-actions · 2026-03-14T06:19:24Z

src/apps/review/src/lib/components/TableReview/TableReview.tsx

 } from 'react'
 import { Link } from 'react-router-dom'
 import { toast } from 'react-toastify'
+import { useSWRConfig } from 'swr'


[⚠️ correctness]
Ensure that useSWRConfig is used correctly and that the mutate function is called with valid cache keys. Improper usage can lead to cache inconsistencies.

github-actions · 2026-03-14T06:19:24Z

src/apps/review/src/lib/components/TableReview/TableReview.tsx

        [aggregatedRows],
    )

+    const escalationDecisionBySubmissionId = useMemo<Map<string, AiReviewEscalationDecision>>(


[⚠️ correctness]
The use of useMemo with a Map can lead to unexpected behavior if the map is mutated after creation. Consider using an immutable data structure or ensure the map is not modified.

github-actions · 2026-03-14T06:19:24Z

src/apps/review/src/lib/components/TableReview/TableReview.tsx

+        [aggregatedRows, aiReviewDecisionsBySubmissionId, challengeInfo?.id],
+    )
+
+    const isSubmissionAiLocked = useCallback((


[❗❗ correctness]
The isSubmissionAiLocked function relies on the status property being exactly 'AI_FAILED_REVIEW'. Ensure that this status is consistently set and checked throughout the application.

src/apps/review/src/lib/components/TableReview/TableReview.tsx

github-actions · 2026-03-14T06:19:24Z

src/apps/review/src/lib/components/TableReview/TableReview.tsx

            )
        }

+        const buildEscalateAction = (): JSX.Element | undefined => {


[⚠️ readability]
The buildEscalateAction function contains nested conditions that could be refactored for clarity. Consider breaking it into smaller functions or using early returns to simplify the logic.

github-actions · 2026-03-14T06:19:29Z

src/apps/review/src/lib/hooks/useFetchAiReviewEscalations.ts

+                submissionId: args.submissionId,
+                submissionLocked: args.submissionLocked,
+            }),
+            isPaused: () => !args.challengeId && !args.submissionId && !args.aiReviewDecisionId,


[⚠️ correctness]
The isPaused function checks if challengeId, submissionId, and aiReviewDecisionId are all undefined, which pauses the fetch. This could lead to unexpected behavior if the user intends to fetch data with only one of these parameters. Consider revising this logic to ensure it aligns with the intended use cases.

github-actions · 2026-03-14T06:19:32Z

src/apps/review/src/lib/models/AiReview.model.ts

    finalizedAt: string | null
    createdAt: string
    updatedAt: string
+    escalations?: AiReviewDecisionEscalation[]


[⚠️ maintainability]
Consider using a non-nullable array for escalations if it is always expected to be an array, even if empty. This can simplify handling of the property by avoiding null checks.

github-actions · 2026-03-14T06:19:36Z

src/apps/review/src/lib/models/SubmissionInfo.model.ts

+ * @param status - The status value from backend (can be number or string)
+ * @returns Normalized status string
+ */
+function normalizeSubmissionStatus(status: BackendSubmissionStatus | string | undefined): string | undefined {


[⚠️ correctness]
The function normalizeSubmissionStatus returns undefined if the input status is neither a number nor a string. Consider whether this behavior is intentional and if it should be handled explicitly in the calling code to avoid potential issues with unexpected undefined values.

src/apps/review/src/lib/services/aiReviewEscalation.service.ts

github-actions · 2026-03-14T06:19:40Z

src/apps/review/src/lib/services/aiReviewEscalation.service.ts

+    if (params.submissionId) query.set('submissionId', params.submissionId)
+    if (params.aiReviewDecisionId) query.set('aiReviewDecisionId', params.aiReviewDecisionId)
+    if (params.status) query.set('status', params.status)
+    if (params.submissionLocked !== undefined) query.set('submissionLocked', String(params.submissionLocked))


[⚠️ correctness]
Using String(params.submissionLocked) to convert a boolean to a string might lead to unexpected results if params.submissionLocked is null or undefined. Consider explicitly checking for true or false values to ensure the query parameter is correctly set.

devin-ai-integration

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

src/apps/review/src/lib/components/TableReview/EscalationModals.tsx

Copilot

Pull request overview

Adds UI + client-side wiring in the Review app to support AI review escalation/unlock flows for AI-failed submissions (PM-3906), including new API service helpers, models, and table actions/modals.

Changes:

Introduce AI review escalation service + hook and export them from the library.
Extend AI review/submission models to include escalation data and the new AI_FAILED_REVIEW status.
Update TableReview to display an “AI Locked” state and provide Escalate/Verify/Unlock actions via new modals.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/apps/review/src/lib/services/index.ts	Exposes the new escalation service from the services barrel.
src/apps/review/src/lib/services/aiReviewEscalation.service.ts	Adds list/create/update escalation API calls and cache key builder.
src/apps/review/src/lib/models/SubmissionInfo.model.ts	Adds normalized submission status onto the frontend submission model.
src/apps/review/src/lib/models/BackendSubmissionStatus.enum.ts	Adds `AI_FAILED_REVIEW` backend submission status.
src/apps/review/src/lib/models/AiReview.model.ts	Adds escalation types and `escalations` on `AiReviewDecision`.
src/apps/review/src/lib/hooks/useFetchAiReviewEscalations.ts	Adds SWR hook to fetch escalation decisions.
src/apps/review/src/lib/hooks/index.ts	Exposes the new hook from the hooks barrel.
src/apps/review/src/lib/components/TableReview/TableReview.tsx	Adds AI lock detection + new actions and renders escalation modals.
src/apps/review/src/lib/components/TableReview/TableReview.module.scss	Adds styles for AI Locked pill and escalation modals; tweaks spacing.
src/apps/review/src/lib/components/TableReview/EscalationModals.tsx	Implements Escalate/Verify/Unlock modal flows and API calls.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

kkartunov · 2026-03-15T16:13:42Z

src/apps/review/src/lib/services/aiReviewEscalation.service.ts

+
+export type AiReviewEscalationStatus = 'PENDING_APPROVAL' | 'APPROVED' | 'REJECTED'
+
+export interface AiReviewDecisionEscalation {
+    id: string
+    aiReviewDecisionId: string
+    escalationNotes: string | null
+    approverNotes: string | null
+    status: AiReviewEscalationStatus
+    createdAt: string
+    createdBy: string | null
+    updatedAt: string
+    updatedBy: string | null
+}
+
+export interface AiReviewEscalationDecision {
+    aiReviewDecisionId: string
+    submissionId: string
+    challengeId: string | undefined
+    decisionStatus: string
+    submissionLocked: boolean
+    escalations: AiReviewDecisionEscalation[]
+}
+


@vas3a please let's use only one location definintion for those

src/apps/review/src/lib/components/TableReview/EscalationModals.tsx

+            closeEscalateDialog()
+            if (props.challengeId) {
+                await refreshChallengeReviewData(props.challengeId)
+            }
+
+            await props.revalidateEscalationData()
+        } catch (error) {


src/apps/review/src/lib/components/TableReview/EscalationModals.tsx

src/apps/review/src/lib/components/TableReview/TableReview.tsx

+                    map.set(String(resource.memberId), {
+                        color: (resource as any).handleColor ?? undefined,


src/apps/review/src/lib/components/TableReview/EscalationModals.tsx

src/apps/review/src/lib/components/TableReview/TableReview.tsx

kkartunov · 2026-03-15T16:13:42Z

src/apps/review/src/lib/services/aiReviewEscalation.service.ts

+
+export type AiReviewEscalationStatus = 'PENDING_APPROVAL' | 'APPROVED' | 'REJECTED'
+
+export interface AiReviewDecisionEscalation {
+    id: string
+    aiReviewDecisionId: string
+    escalationNotes: string | null
+    approverNotes: string | null
+    status: AiReviewEscalationStatus
+    createdAt: string
+    createdBy: string | null
+    updatedAt: string
+    updatedBy: string | null
+}
+
+export interface AiReviewEscalationDecision {
+    aiReviewDecisionId: string
+    submissionId: string
+    challengeId: string | undefined
+    decisionStatus: string
+    submissionLocked: boolean
+    escalations: AiReviewDecisionEscalation[]
+}
+


@vas3a please let's use only one location definintion for those

vas3a added 8 commits March 11, 2026 08:57

PM-3926 - show locked state

9a347c2

Merge branch 'dev' of github.com:topcoder-platform/platform-ui into P…

834f9fc

…M-3926_ai-screening-phase

PM-3906 wip

47bdd90

Merge branch 'dev' of github.com:topcoder-platform/platform-ui into P…

ce935d0

…M-3906_ai-review-escalation

PM-3906 #time 4.5h review escalation

fcb817d

PM-3906 #time 1.5h fixes to modals & lint

e984e74

PM-3906 #time 30m use ai decission.escalation, unlock submission

031d917

PM-3906 #time 5m re-validate ai decissions once we submit escalation

7672e1d

vas3a requested review from jmgasper and kkartunov as code owners March 14, 2026 06:18

github-actions bot reviewed Mar 14, 2026

View reviewed changes

devin-ai-integration bot reviewed Mar 14, 2026

View reviewed changes

src/apps/review/src/lib/components/TableReview/EscalationModals.tsx Show resolved Hide resolved

kkartunov requested a review from Copilot March 15, 2026 15:41

Copilot started reviewing on behalf of kkartunov March 15, 2026 15:42 View session

Copilot AI reviewed Mar 15, 2026

View reviewed changes

kkartunov requested changes Mar 15, 2026

View reviewed changes

		map.set(String(resource.memberId), {
		color: (resource as any).handleColor ?? undefined,

Conversation

vas3a commented Mar 14, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related JIRA Ticket:

What's in this PR?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

kkartunov Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kkartunov Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

vas3a commented Mar 14, 2026 •

edited by devin-ai-integration bot

Loading