Skip to content

PM-4309 remove ai reviewers when removing config #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vas3a merged 1 commit into from
Mar 16, 2026
Merged

PM-4309 remove ai reviewers when removing config #1740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/ChallengeEditor/ChallengeReviewer-Field/AiReviewerTab/AiReviewTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,13 @@ const AiReviewTab = ({ challenge, onUpdateReviewers, metadata = {}, isLoading, r
console.error('Error deleting AI review configuration:', err)
})
}

const updatedReviewers = (challenge.reviewers || []).filter(reviewer => !isAIReviewer(reviewer))
onUpdateReviewers({ field: 'reviewers', value: updatedReviewers })

setConfigurationMode(null)
resetConfiguration()
}, [setConfigurationMode, resetConfiguration, configId])
}, [challenge.reviewers, configId, onUpdateReviewers, resetConfiguration, setConfigurationMode])
Copy link

@github-actions github-actions bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ performance]
The dependency array for the useCallback hook now includes challenge.reviewers, which is an array. This could lead to unnecessary re-creations of the callback if the array reference changes, even if its contents do not. Consider using a stable reference or a different approach to avoid unnecessary re-renders.


const handleSwitchConfigurationMode = useCallback((mode, template) => {
if (mode === 'manual') {
Expand Down
Loading