Skip to content

PM-4302 ai config fixes#1742

Merged
vas3a merged 2 commits intodevelopfrom
PM-4302_ai-config-fixes
Mar 17, 2026
Merged

PM-4302 ai config fixes#1742
vas3a merged 2 commits intodevelopfrom
PM-4302_ai-config-fixes

Conversation

@vas3a
Copy link
Collaborator

@vas3a vas3a commented Mar 17, 2026

  • The logic for showing the virtual AI screening phase now considers both "Submission" and "Checkpoint Submission" phases, ensuring the AI screening phase appears appropriately after either phase if present.
  • The fallback display of the virtual AI screening phase is updated to handle the absence of either "Submission" or "Checkpoint Submission" phases, improving robustness.
  • The "AI_ONLY" option is now hidden from the review mode dropdown in the ReviewSettingsSection component.

}}
/>
{showVirtualAiScreening && index === submissionIndex && (
{showVirtualAiScreening && (index === submissionIndex || index === checkpointSubmissionIndex) && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
The condition (index === submissionIndex || index === checkpointSubmissionIndex) is repeated multiple times in the code. Consider extracting this logic into a well-named function to improve maintainability and readability.

</React.Fragment>
))}
{showVirtualAiScreening && submissionIndex === -1 && (
{showVirtualAiScreening && (submissionIndex === -1 || checkpointSubmissionIndex === -1) && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
The condition (submissionIndex === -1 || checkpointSubmissionIndex === -1) is repeated multiple times in the code. Consider extracting this logic into a well-named function to improve maintainability and readability.

@vas3a vas3a merged commit 86fa6ce into develop Mar 17, 2026
6 checks passed
@vas3a vas3a deleted the PM-4302_ai-config-fixes branch March 17, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant