prevent cb to be called twice in some error case#95
Open
super-ienien wants to merge 1 commit intototemstech:masterfrom
Open
prevent cb to be called twice in some error case#95super-ienien wants to merge 1 commit intototemstech:masterfrom
super-ienien wants to merge 1 commit intototemstech:masterfrom
Conversation
|
👍 Have also seen this happen, it would be awesome if this could get merged in. |
|
+1 |
1 similar comment
|
+1 |
|
This is still relevant. Any possibilities that this gets merged into the core? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent cb to be called twice in some error case.
For exemple : when the error ECONRESET is thrown the callback was called twice.