Repository navigation
🐛 fix(windows): keep trailing Unicode whitespace in overrides - #700
Merged
gaborbernat merged 3 commits intoNov 17, 2026
Merged
Conversation
A fully qualified path cannot start with whitespace, so a value pasted with a leading no-break space was accepted before and should still be; only trailing non-ASCII whitespace can belong to the folder name. Move the rule next to the other override value rules in the explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
WIN_PD_OVERRIDE_*value whose folder name ends in a non-ASCII space, such asX:\datafollowed by a no-break space (U+00A0), resolved to a different folder, because the trailing character was stripped along with ordinary padding. 🪟 Once this merges, the override points at the folder the user named.The override still drops ASCII spaces, tabs and line breaks at either end, so padding copied into the variable keeps working, and still drops any whitespace before the value, since a fully qualified path cannot start with it. Only trailing non-ASCII whitespace, which Windows allows at the end of a folder name, is now kept. The explanation page lists this next to the other rules for which override values are accepted.