Skip to content

🐛 fix(windows): keep trailing Unicode whitespace in overrides - #700

Merged
gaborbernat merged 3 commits into
tox-dev:mainfrom
subotac:fix/windows-override-whitespace
Nov 17, 2026
Merged

gaborbernat merged 3 commits into
tox-dev:mainfrom
subotac:fix/windows-override-whitespace

Conversation

@subotac

@subotac subotac commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

A WIN_PD_OVERRIDE_* value whose folder name ends in a non-ASCII space, such as X:\data followed by a no-break space (U+00A0), resolved to a different folder, because the trailing character was stripped along with ordinary padding. 🪟 Once this merges, the override points at the folder the user named.

The override still drops ASCII spaces, tabs and line breaks at either end, so padding copied into the variable keeps working, and still drops any whitespace before the value, since a fully qualified path cannot start with it. Only trailing non-ASCII whitespace, which Windows allows at the end of a folder name, is now kept. The explanation page lists this next to the other rules for which override values are accepted.

A fully qualified path cannot start with whitespace, so a value pasted
with a leading no-break space was accepted before and should still be;
only trailing non-ASCII whitespace can belong to the folder name. Move
the rule next to the other override value rules in the explanation.
@gaborbernat gaborbernat changed the title fix(windows): preserve Unicode whitespace in folder overrides 🐛 fix(windows): keep trailing Unicode whitespace in overrides Nov 17, 2026
@gaborbernat gaborbernat added the bug Something isn't working label Nov 17, 2026
@gaborbernat
gaborbernat merged commit e8c70dd into tox-dev:main Nov 17, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants