Repository navigation
🐛 fix(unix): drop a backslash before a user-dirs.dirs line break - #721
Merged
Merged
Conversation
Since tox-dev#712 strips the whole line ending before matching, the backslash tox-dev#716 keeps only at the end of the file also matched before a newline, so $HOME/Docs\ followed by a line break kept its backslash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has failed every test job since 4.14.6 (run), and 4.14.6 keeps the backslash in an unquoted
user-dirs.dirsvalue such asXDG_DOCUMENTS_DIR=$HOME/Docs\followed by a line break, so the folder name ends in\. 🔧 Once this merges, that backslash is dropped and main is green again.#712 strips the whole line ending before a line is matched, while #716 keeps a backslash only when nothing follows it in the file. Each passed on its own; together, a backslash before a line break looked like one at the end of the file. The reader now drops only the carriage return of a Windows line ending and keeps the line feed, so the two cases stay apart. A backslash at the very end of the file is still kept, as the shell keeps it.