Repository navigation
fix: preserve hitbox packet conversion until client removal - #468
Merged
Merged
Conversation
Track disguised hitbox IDs per connection so queued living-entity metadata cannot reach ItemDisplays after the server entity disappears. Apply packet-ordered cleanup across Bukkit adapters and Fabric, and complete suppressed write promises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the metadata mismatch reported in #445.
When a hitbox is removed before its queued packets are processed, BetterModel can send living-entity metadata to a client that knows the entity as an ItemDisplay, disconnecting the player.
The change keeps track of hitbox IDs per connection instead of relying on the entity still being available in the world.
Builds and local regression checks passed on Paper and Folia 26.3.
Older MC versions and Fabric were compile-checked only.
No public API or dependency changes.
Before:
https://github.com/user-attachments/assets/a192a1dd-5d79-43ab-937f-cbefff96d6af
After:
https://github.com/user-attachments/assets/9345bdeb-6831-40c2-af56-178543f8a620