Fix raspberry pi pico example not compiling

[BjornTheProgrammer]

Pull Request Template

Checklist

• Confirmed that cargo run-checks command has been executed.
• Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Just this PR.

Changes

This just removes the unsafe-assume-single-core that ends up breaking the raspberry-pi-pico from compiling, since you can't use critical section.

Testing

I've removed the raspberry-pi-pico exclude from the Cargo.toml, since it seems like it is working now.

[BjornTheProgrammer]

Attempting to fix CI issue in embassy-rs/embassy#4909, before proceeding further

[BjornTheProgrammer]

Additionally xtask doc needs to probably be updated to get the check to pass properly

[laggui]

Thanks for keeping the example up to date 😄

LGTM, pending the dependency audit issue

[BjornTheProgrammer]

I've gotten embassy-rs/embassy#4948 merged, but now it seems that xtask might have changed a little since two weeks ago. I'll look into the underlying issue and submit a PR if needed.

[laggui]

I've gotten embassy-rs/embassy#4948 merged, but now it seems that xtask might have changed a little since two weeks ago. I'll look into the underlying issue and submit a PR if needed.

Hmmm not sure, we're delayed the xtask version changes due to breaking changes so I don't think it has changed.

I think the example should only be compiled for the correct target, otherwise CI will fail.

[BjornTheProgrammer]

When running cargo clippy it runs for every single package in the workspace, and there doesn't seem to be a way to exclude an example or package to be excluded from compiling currently, as seen in rust-lang/rust-clippy#9555

[BjornTheProgrammer]

I'm just gonna exclude the example from the workspace like it was previously, which means that future changes still can break it. Until cargo clippy adds a way to exclude, I don't see an easy way to do this. At the very least, this should ensure that 0.20.0-pre.5 and 0.20.0 still works with the microcontrollers.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.01%. Comparing base (20dadd7) to head (e167713).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4034   +/-   ##
=======================================
  Coverage   68.01%   68.01%           
=======================================
  Files        1264     1264           
  Lines      152722   152722           
=======================================
  Hits       103876   103876           
  Misses      48846    48846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[laggui]

Until cargo clippy adds a way to exclude, I don't see an easy way to do this.

Ahhh ok so it was clippy. Makes sense.

Thanks for the update!