merge upstream build (beta) #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add a note at the end about the mailers, and the `lib/` folder in general.
Add notes about removing from `spec` dir
Should've done this as part of #438, my bad!
Add information about custom rake tasks and rakelib folder
Update 'Use Your Own ORM' guide for 1.0
Fix a typo
If tests at spec/web/views/application_layout_spec.rb are left to run, the result set is different from what's on the pages which looks confusings for starters. Got me looking around trying to find why I'm not getting same results like the guide
Fix example
Fix a couple of sentences and example code.
Fix invalid expectation in action spec
This is Hanami 2.2 release announcement. So guide for v2.2 is more appropriate I think.
* Update Gemfile.lock * Rework CI status page Make it much simpler now that we don't need to worry about the migration from Hanami 1 to 2
* Remove .ruby-version 2.7 We already have .tool-versions with 3.4.2 so that should take precedence. In the Netlify logs it said: > mise WARN deprecated [idiomatic_version_file_enable_tools]: > Idiomatic version files like /opt/build/repo/.ruby-version are currently enabled by default. However, this will change in mise 2025.10.0 to instead default to disabled. > You can remove this warning by explicitly enabling idiomatic version files for ruby with: > mise settings add idiomatic_version_file_enable_tools ruby > You can disable idiomatic version files with: > mise settings add idiomatic_version_file_enable_tools * Add .ruby-version with 3.4.2 * Revert to Ruby 2.7.5
Bring this into line with what I shared in a recent presentation, and the blog post at https://hanamirb.org/blog/2025/07/11/hanami-and-the-elephant-in-the-room/.
The recording of this talk is being revised and it will be up again soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.