Upgrade to Go 1.25 #9771
Merged
Upgrade to Go 1.25 #9771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nopcoder
commented
Dec 9, 2025
nopcoder
commented
- Update dockerfile
- Update go.mod
- Update github workflows
- Update esti
- Update jpebble test docker container
- Github workflow match go version based on go.mod
- Update dockerfile - Update go.mod - Update github workflows - Update esti - Update jpebble test docker container - Github workflow match go version based on go.mod
github-actions
bot
added
area/testing
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to upgrade the project from Go 1.24.4 to Go 1.25.5, but there is a critical issue: Go 1.25.5 does not exist. As of January 2025, the latest stable Go release was 1.23.x, and Go 1.24 had not yet been officially released.
Key changes attempted:
- Update Go version from 1.24.4 to 1.25.5 across all go.mod files
- Upgrade GitHub Actions setup-go from v4 to v6 with go-version-file for dynamic version management
- Update Docker images from golang:1.24-alpine to golang:1.25-alpine
- Update various Go dependencies to versions compatible with the intended Go upgrade
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Update Go version to 1.25.5 and upgrade dependencies (nonexistent version) |
| go.work | Update workspace Go version to 1.25.5 (nonexistent version) |
| webui/go.mod | Update Go version to 1.25.5 (nonexistent version) |
| modules/*/factory/go.mod | Update Go version to 1.25.5 across all module factory files (nonexistent version) |
| go.sum, go.work.sum | Update dependency checksums for new Go version and dependencies |
| Dockerfile | Update base image to golang:1.25-alpine (nonexistent image tag) |
| esti/ops/docker-compose-common.yaml | Update esti container to golang:1.25-alpine (nonexistent image tag) |
| clients/spark/src/test/scala/io/treeverse/jpebble/BlockParserSpec.scala | Update test container to golang:1.25-alpine (nonexistent image tag) |
| .github/workflows/*.yaml | Upgrade actions/setup-go from v4 to v6 and switch from hardcoded version to go-version-file for better maintainability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arielshaqed
approved these changes
Dec 14, 2025
Contributor
arielshaqed
left a comment
arielshaqed
left a comment
There was a problem hiding this comment.
Neat, thanks!
But worst Copilot review EVER.
nopcoder
added
the
exclude-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.