-
Notifications
You must be signed in to change notification settings - Fork 417
(fork) ci: run tests without bencher on PRs from fork #9830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modifies the GitHub Actions workflow to handle test execution gracefully when running from forked repositories. When BENCHER_API_TOKEN is unavailable (as it is for PRs from forks), the workflow now runs tests directly using make test-go instead of failing when attempting to use bencher with an empty token.
Key Changes:
- Added conditional logic to check if
BENCHER_API_TOKENis available before using bencher - Falls back to running
make test-godirectly when the token is not present
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --project lakefs \ | ||
| --branch "$ref" \ | ||
| --testbed "github-${release_slug}" \ | ||
| make test-go |
Copilot
AI
Dec 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation of the bencher command arguments is inconsistent. Line 67 has an extra space compared to lines 66, 68, and 69, which makes the alignment uneven. All continuation lines should have consistent indentation for better readability.
| --project lakefs \ | |
| --branch "$ref" \ | |
| --testbed "github-${release_slug}" \ | |
| make test-go | |
| --project lakefs \ | |
| --branch "$ref" \ | |
| --testbed "github-${release_slug}" \ | |
| make test-go |
arielshaqed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS!
(What Copilot said is true. Welcome to the future, where instead of linters we have AI...)
|
@arielshaqed, could you please merge this PR? A few required checks are skipped, so I cannot merge this. Same with #9805. :) |
BENCHER_API_TOKEN secret is not available when running from forks, due to which bencher receives empty string and fails. Eg: https://github.com/treeverse/lakeFS/actions/runs/20267951059/job/58195889535?pr=9805.
83cbd1e to
d7ed6d4
Compare
BENCHER_API_TOKENsecret is not available when running from forks, due to which bencher receives empty string and fails.Eg: https://github.com/treeverse/lakeFS/actions/runs/20267951059/job/58195889535?pr=9805.
This will run
make test-gowhen not the secret is not available.