Skip to content

Conversation

@skshetry
Copy link
Contributor

BENCHER_API_TOKEN secret is not available when running from forks, due to which bencher receives empty string and fails.

Eg: https://github.com/treeverse/lakeFS/actions/runs/20267951059/job/58195889535?pr=9805.

This will run make test-go when not the secret is not available.

@skshetry skshetry added the exclude-changelog PR description should not be included in next release changelog label Dec 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the GitHub Actions workflow to handle test execution gracefully when running from forked repositories. When BENCHER_API_TOKEN is unavailable (as it is for PRs from forks), the workflow now runs tests directly using make test-go instead of failing when attempting to use bencher with an empty token.

Key Changes:

  • Added conditional logic to check if BENCHER_API_TOKEN is available before using bencher
  • Falls back to running make test-go directly when the token is not present

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +67 to +70
--project lakefs \
--branch "$ref" \
--testbed "github-${release_slug}" \
make test-go
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of the bencher command arguments is inconsistent. Line 67 has an extra space compared to lines 66, 68, and 69, which makes the alignment uneven. All continuation lines should have consistent indentation for better readability.

Suggested change
--project lakefs \
--branch "$ref" \
--testbed "github-${release_slug}" \
make test-go
--project lakefs \
--branch "$ref" \
--testbed "github-${release_slug}" \
make test-go

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!

(What Copilot said is true. Welcome to the future, where instead of linters we have AI...)

@skshetry
Copy link
Contributor Author

@arielshaqed, could you please merge this PR? A few required checks are skipped, so I cannot merge this.

Same with #9805. :)

BENCHER_API_TOKEN secret is not available when running from forks,
due to which bencher receives empty string and fails.

Eg: https://github.com/treeverse/lakeFS/actions/runs/20267951059/job/58195889535?pr=9805.
@itaiad200 itaiad200 added the minor-change Used for PRs that don't require issue attached label Dec 22, 2025
@skshetry skshetry changed the title ci: run tests without bencher on PRs from fork (fork) ci: run tests without bencher on PRs from fork Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants