Add IsProductionSafe to Blockstore metadata [v2] #9839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
added
exclude-changelog
github-actions
bot
added
area/testing
itaigilo
changed the title
idanovo
requested changes
Dec 18, 2025
Contributor
idanovo
left a comment
idanovo
left a comment
There was a problem hiding this comment.
I'm not sure how come the local store is production safe, maybe I'm missing something
| func (l *Adapter) BlockstoreMetadata(_ context.Context) (*block.BlockstoreMetadata, error) { | ||
| return nil, block.ErrOperationNotSupported | ||
| return &block.BlockstoreMetadata{ | ||
| IsProductionSafe: true, |
Contributor
There was a problem hiding this comment.
How come the local adapter is production safe?
Contributor
Author
There was a problem hiding this comment.
We do have a bunch of customers using local adapter in Prod.
itaigilo
commented
Dec 18, 2025
Contributor
Author
There was a problem hiding this comment.
This is about trying to fix OSS integration in Enterprise.
Might be reverted soon.
itaigilo
commented
Dec 18, 2025
Contributor
Author
There was a problem hiding this comment.
Also here, fixing Enterprise E2E.
idanovo
approved these changes
Dec 18, 2025
github-actions
bot
removed
the
area/auth
N-o-Z
pushed a commit
that referenced
this pull request
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8681.
Recreates #9822 (for technical reasons).
This PR is used for Enterprise.
Change Description
Making production warning for blockstores part of the Blockstore Adapter metadata.
Testing Details
Tested the warning locally (appears for "mem", doesn't for other types).
Also, unit and integration tests in the blockstore area provide a pretty decent coverage.