Cleanup unit tests #1402
Merged
Cleanup unit tests #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly used in one test, we can move the unit test so it doesn't require special access functions
squell
force-pushed
the
cleanup-unit-tests
branch
from
d38cb42 to
62d1d30
Compare
squell
added
chore
bjorn3
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working in the AST again after a while was a pleasant experience, but I noticed we had accumulated quite a bit of #[cfg(test)] accessory functions that have only been added because
assert_matches!()has still not landed. I didn't like having the mixed in with production code for readability, but also at some point one could be tempted to write test code that is only exercising the auxilliary function that are only there to aid testing.So this PR has some commits that move things around.
In any case I do want to changes in the
sudoers/folder to stick, but I think the same change also helps in the CLI.