Skip to content

Commit d52e08d

Browse files
Fix_ElixirDGMulti_ShuOsher (#2618)
Co-authored-by: Hendrik Ranocha <[email protected]>
1 parent 8cf4e3c commit d52e08d

File tree

2 files changed

+8
-16
lines changed

2 files changed

+8
-16
lines changed

examples/dgmulti_1d/elixir_euler_shu_osher_gauss_shock_capturing.jl

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,7 @@ end
3232

3333
initial_condition = initial_condition_shu_osher
3434

35-
# Up to version 0.13.0, `max_abs_speed_naive` was used as the default wave speed estimate of
36-
# `const flux_lax_friedrichs = FluxLaxFriedrichs(), i.e., `FluxLaxFriedrichs(max_abs_speed = max_abs_speed_naive)`.
37-
# In the `StepsizeCallback`, though, the less diffusive `max_abs_speeds` is employed which is consistent with `max_abs_speed`.
38-
# Thus, we exchanged in PR#2458 the default wave speed used in the LLF flux to `max_abs_speed`.
39-
# To ensure that every example still runs we specify explicitly `FluxLaxFriedrichs(max_abs_speed_naive)`.
40-
# We remark, however, that the now default `max_abs_speed` is in general recommended due to compliance with the
41-
# `StepsizeCallback` (CFL-Condition) and less diffusion.
42-
surface_flux = FluxLaxFriedrichs(max_abs_speed_naive)
35+
surface_flux = flux_lax_friedrichs
4336
volume_flux = flux_ranocha
4437

4538
polydeg = 3
@@ -92,7 +85,7 @@ save_solution = SaveSolutionCallback(interval = 100,
9285
solution_variables = cons2prim)
9386

9487
# handles the re-calculation of the maximum Δt after each time step
95-
stepsize_callback = StepsizeCallback(cfl = 0.2)
88+
stepsize_callback = StepsizeCallback(cfl = 0.13)
9689

9790
# collect all callbacks such that they can be passed to the ODE solver
9891
callbacks = CallbackSet(summary_callback, analysis_callback, save_solution,

test/test_dgmulti_1d.jl

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,15 @@ end
5757
@trixi_testset "elixir_euler_shu_osher_gauss_shock_capturing.jl " begin
5858
@test_trixi_include(joinpath(EXAMPLES_DIR,
5959
"elixir_euler_shu_osher_gauss_shock_capturing.jl"),
60-
cells_per_dimension=(64,), tspan=(0.0, 1.0),
6160
l2=[
62-
1.6967151731067875,
63-
6.018445633981826,
64-
21.77425594743242
61+
1.696712726264938,
62+
6.018435800027037,
63+
21.774221602026298
6564
],
6665
linf=[
67-
3.2229876650556477,
68-
10.702690533393842,
69-
38.37424900889908
66+
3.2229930998898952,
67+
10.702431261492814,
68+
38.37420027341893
7069
])
7170
# Ensure that we do not have excessive memory allocations
7271
# (e.g., from type instabilities)

0 commit comments

Comments
 (0)