fix(txgen): build-txgen-falcon graceful liboqs skip; document Falcon …#201
Merged
Merged
Conversation
…keygen + config - Makefile: the liboqs-absent branch called `exit 0` in a separate recipe line, so Make still ran the build line and hard-failed when liboqs was missing — contrary to the documented "skip with exit 0 so CI won't fail". Join the liboqs check, mkdir, and build into one shell command so the skip exits the whole recipe; build path unchanged when liboqs is present. - README: add "Falcon-512 (FN_DSA_512) setup" — the `txgen keygen` command, an FN_DSA_512 config example (privateKey/publicKey instead of seed), and per-scheme provisioning. Previously the README named FN_DSA_512 but never said how to obtain its keys. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kuny0707
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…keygen + config
exit 0in a separate recipe line, so Make still ran the build line and hard-failed when liboqs was missing — contrary to the documented "skip with exit 0 so CI won't fail". Join the liboqs check, mkdir, and build into one shell command so the skip exits the whole recipe; build path unchanged when liboqs is present.txgen keygencommand, an FN_DSA_512 config example (privateKey/publicKey instead of seed), and per-scheme provisioning. Previously the README named FN_DSA_512 but never said how to obtain its keys.