Skip to content

[chore] Cleanup unnecessary deps #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
gnalh wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[chore] Cleanup unnecessary deps #959

gnalh wants to merge 1 commit into from

Conversation

@gnalh
Copy link
Collaborator

@gnalh gnalh commented Dec 29, 2025

No description provided.

@trunk-io
Copy link

trunk-io bot commented Dec 29, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@gnalh gnalh force-pushed the gabe/cleanup-deps branch from d4b29c2 to 295a597 Compare December 29, 2025 23:57
@trunk-staging-io
Copy link

trunk-staging-io bot commented Dec 30, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

TylerJang27
TylerJang27 approved these changes Dec 30, 2025
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an iwyu for cargo?

Stamped pending CI passing

@gnalh
Copy link
Collaborator Author

gnalh commented Dec 30, 2025

Is there an iwyu for cargo?

Stamped pending CI passing

There's https://github.com/bnjbvr/cargo-machete, but it often deletes more dependencies than you actually want and breaks the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerJang27 TylerJang27 TylerJang27 approved these changes

@cmillar-trunk cmillar-trunk Awaiting requested review from cmillar-trunk cmillar-trunk will be requested when the pull request is marked ready for review cmillar-trunk is a code owner

@mb1206 mb1206 Awaiting requested review from mb1206 mb1206 will be requested when the pull request is marked ready for review mb1206 is a code owner

@acatxnamedvirtue acatxnamedvirtue Awaiting requested review from acatxnamedvirtue acatxnamedvirtue will be requested when the pull request is marked ready for review acatxnamedvirtue is a code owner

@max-trunk max-trunk Awaiting requested review from max-trunk max-trunk will be requested when the pull request is marked ready for review max-trunk is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gnalh @TylerJang27