Skip to content

Conversation

@max-trunk
Copy link
Contributor

@max-trunk max-trunk commented Jan 2, 2026

TRUNK-17241

Cleans up the rspec plugin output for when quarantining is disabled for the repo. Re-iterating that this doesn't change any functionality, only messaging / output

Previously, when quarantining was disabled via repo settings, we'd still print Test failed, checking if it can be quarantined: ... before every test failure even though we never quarantine these failures. Now, when quarantining is disabled, we only print this once when we encounter the first failure (when we make the network call to /getQuarantineConfig) before printing that Quarantining is disabled for this repo, no failures will be quarantined. A note re-emphasizing this is also printed at the end of the invocation for clarity.

Tested with a locally-built gem:

Example run with quarantining disabled & 2 test failures Screenshot 2026-01-02 at 2 18 40 PM
Example run with quarantining enabled & 2 test failures Screenshot 2026-01-02 at 3 18 34 PM

Also updates the caching logic to include the quarantining_disabled_for_repo signal returned from /getQuarantineConfig

@trunk-io
Copy link

trunk-io bot commented Jan 2, 2026

😎 Merged successfully - details.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.09%. Comparing base (8b20e46) to head (e43a74b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test_report/src/report.rs 80.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   80.81%   81.09%   +0.27%     
==========================================
  Files          66       66              
  Lines       14081    14100      +19     
==========================================
+ Hits        11380    11434      +54     
+ Misses       2701     2666      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-trunk max-trunk marked this pull request as ready for review January 2, 2026 20:41
@trunk-staging-io
Copy link

trunk-staging-io bot commented Jan 2, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

1 similar comment
@trunk-staging-io
Copy link

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io trunk-io bot merged commit 5fbfd20 into main Jan 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants