Cleanup rspec plugin output for when quarantining is disabled for the repo #966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRUNK-17241
Cleans up the rspec plugin output for when quarantining is disabled for the repo. Re-iterating that this doesn't change any functionality, only messaging / output
Previously, when quarantining was disabled via repo settings, we'd still print
Test failed, checking if it can be quarantined: ...before every test failure even though we never quarantine these failures. Now, when quarantining is disabled, we only print this once when we encounter the first failure (when we make the network call to/getQuarantineConfig) before printing thatQuarantining is disabled for this repo, no failures will be quarantined. A note re-emphasizing this is also printed at the end of the invocation for clarity.Tested with a locally-built gem:
Example run with quarantining disabled & 2 test failures
Example run with quarantining enabled & 2 test failures
Also updates the caching logic to include the
quarantining_disabled_for_reposignal returned from/getQuarantineConfig