Repository navigation
fix: revalidate DatePicker format changes - #3598
Merged
Merged
Conversation
Re-run native constraint validation when dateFormat changes for the current input value. Semver: patch (non-breaking)
brandonlenz
approved these changes
Oct 23, 2026
Contributor
|
Going to get this one merging so that we have a releasable candidate. There is some unnecessary spelling out of implementation details in storybook in this one too, but that also happened to already be the case for this component, so non-blocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dateFormatchangesThe validation effect omitted
dateFormat, so a value could remain marked valid after the accepted format changed. This PR adds the missing reactive input and a regression test that changes the format without changing the value.Related Issues
#3585
How To Test
npm run test -- src/components/forms/DatePicker.npm run lint.npm run format:check.The full test, coverage, build, server-side, Storybook, lint, format, and production-audit checks pass locally on Node 26.3.0.
Semver
Patch, non-breaking. No public API changes.