Wire scan executor/sidecar env vars into compose - #303
Merged
Conversation
This was referenced Sep 3, 2026
haksungjang
force-pushed
the
compose-env-wiring/scan-executor-sidecar
branch
from
September 3, 2026 05:17
500a11a to
83c7d17
Compare
26 vars documented in .env.example (SCAN_EXECUTOR mode selection, Docker
sidecar hardening — resource caps, capabilities, network, volume
strategy — Android scan image selection, scan-log persistence/retention)
were never referenced in x-backend-env, so setting them in .env (e.g.
opting into SCAN_EXECUTOR=docker) had no effect on the running
container. Adds them with defaults matching core/config.py.
SCAN_WORKSPACE_MOUNT is the one exception: the code default
(/tmp/trustedoss) is dev's mount point. docker-compose.yml's named
volume actually mounts the worker at /workspace, per
_docker_volume._workspace_mount()'s own docstring ("prod sets this to
/workspace"), so the prod anchor uses that instead — otherwise a
docker-executor sidecar would resolve source_dir against the wrong
path.
Part of the compose env-var wiring audit.
haksungjang
force-pushed
the
compose-env-wiring/scan-executor-sidecar
branch
from
September 3, 2026 06:18
83c7d17 to
2ae1984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.env.example(SCAN_EXECUTOR mode selection, Docker sidecar hardening — resource caps, capabilities, network, volume strategy — Android scan image selection, scan-log persistence/retention) were never referenced inx-backend-env, so an operator following the docs to opt intoSCAN_EXECUTOR=docker(or tune sidecar limits) via.envsaw no effect.core/config.py.One deliberate deviation from a flat "copy core/config.py's default"
SCAN_WORKSPACE_MOUNT's code default is/tmp/trustedoss(dev's mount point).docker-compose.yml's named volume actually mounts the worker/beat/backend at/workspace(see thevolumes:section), and_docker_volume._workspace_mount()'s own docstring confirms: "prod sets this to /workspace." So the prod anchor uses${SCAN_WORKSPACE_MOUNT:-/workspace}instead of the code default — using the code default there would have made a docker-executor sidecar resolvesource_diragainst the wrong path.Context
Part of the same compose env-var wiring audit as #300/#301. This PR covers the scan-executor/sidecar cluster — the largest single cluster in the audit.
Test plan