-
Notifications
You must be signed in to change notification settings - Fork 5
chore: add Trivy security scan #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add security scan
Reviewer's GuideIntroduce a GitHub Actions workflow that runs Trivy file-system vulnerability scans on push, pull requests, and manual dispatch, generates SARIF and table reports, enforces failure on critical/high findings, and uploads the SARIF output to the GitHub Security tab. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/security-scan.yaml:47` </location>
<code_context>
+ with:
+ sarif_file: trivy-results.sarif
+ category: trivy-security-scan
+ continue-on-error: true
</code_context>
<issue_to_address>
Using `continue-on-error: true` may hide upload failures.
This setting may cause missed security reports if uploads fail. Consider removing it or handling failures to ensure reliable reporting.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| with: | ||
| sarif_file: trivy-results.sarif | ||
| category: trivy-security-scan | ||
| continue-on-error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Using continue-on-error: true may hide upload failures.
This setting may cause missed security reports if uploads fail. Consider removing it or handling failures to ensure reliable reporting.
Summary by Sourcery
Add GitHub Actions workflow to perform Trivy vulnerability scans on pushes, pull requests, and manual triggers, enforce build failure on critical and high findings, and upload SARIF reports to the Security tab
CI: