Skip to content

Conversation

@AmberJBlue
Copy link
Member

@AmberJBlue AmberJBlue commented Aug 14, 2025

Summary by Sourcery

Add GitHub Actions workflow to perform Trivy vulnerability scans on pushes, pull requests, and manual triggers, enforce build failure on critical and high findings, and upload SARIF reports to the Security tab

CI:

  • Introduce security-scan.yaml workflow using Trivy to scan the repository file system for vulnerabilities
  • Configure the workflow to run on main branch events and manual dispatch, output SARIF results, and fail on critical/high severities
  • Upload the generated SARIF report to GitHub Security tab for review

@AmberJBlue AmberJBlue self-assigned this Aug 14, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Aug 14, 2025

Reviewer's Guide

Introduce a GitHub Actions workflow that runs Trivy file-system vulnerability scans on push, pull requests, and manual dispatch, generates SARIF and table reports, enforces failure on critical/high findings, and uploads the SARIF output to the GitHub Security tab.

File-Level Changes

Change Details Files
Add security-scan workflow with Trivy integration
  • Configure triggers for push, pull_request, and workflow_dispatch
  • Define Trivy scan job on ubuntu-latest with read and security-events write permissions
  • Run filesystem scan to produce SARIF output
  • Run filesystem scan to enforce failure on critical/high vulnerabilities
  • Upload SARIF report to GitHub Security tab with error continuation
.github/workflows/security-scan.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@AmberJBlue AmberJBlue marked this pull request as ready for review August 19, 2025 14:34
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `.github/workflows/security-scan.yaml:47` </location>
<code_context>
+        with:
+          sarif_file: trivy-results.sarif
+          category: trivy-security-scan
+        continue-on-error: true
</code_context>

<issue_to_address>
Using `continue-on-error: true` may hide upload failures.

This setting may cause missed security reports if uploads fail. Consider removing it or handling failures to ensure reliable reporting.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

with:
sarif_file: trivy-results.sarif
category: trivy-security-scan
continue-on-error: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Using continue-on-error: true may hide upload failures.

This setting may cause missed security reports if uploads fail. Consider removing it or handling failures to ensure reliable reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant