fix(loracloud): bump request timestamp by 1s on GNSS-NG EoG

[michaelbeutler]

Summary

• When the GNSS-NG header EoG bit is set on a Tag XL uplink, add 1 second to the request timestamp sent to LoRaCloud/Traxmate so the EoG message sorts strictly after the prior captures in the same group.
• Applied in DeliverUplinkMessage after the header is decoded, so both the v1 and v2 Solve paths benefit. The response-side GetTimestamp() surface is unchanged.
• New pointer is allocated so the caller's *float64 is never mutated.

Test plan

• go test ./pkg/solver/loracloud/...
• go test ./pkg/decoder/tagxl/...
• go test ./...
• New tests: EoG bumps by 1s, non-EoG untouched, nil timestamp stays nil, caller pointer not mutated

Summary by CodeRabbit

• New Features

  • End-of-group uplink detection now advances the outgoing request timestamp by 1 second before sending to the LoRa Cloud endpoint to ensure proper ordering.

• Tests

  • Added test coverage validating the end-of-group timestamp adjustment behavior.
  • Added test ensuring caller-provided timestamp values remain unchanged during processing.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1cb51d46-41a8-467c-8440-334f5e98ab77

📥 Commits

Reviewing files that changed from the base of the PR and between 9274acf and 22f2ca1.

📒 Files selected for processing (1)

• .secrets.baseline

---

📝 Walkthrough

Walkthrough

When DeliverUplinkMessage decodes a GNSS‑NG header with EndOfGroup and a non‑nil uplink timestamp, it increments that timestamp by 1 second before sending the HTTP POST. Two unit tests cover adjustment and confirm the caller's timestamp pointer is not mutated. .secrets.baseline line numbers and timestamp updated.

Changes

LoraCloud EndOfGroup Timestamp Adjustment

Layer / File(s)	Summary
EndOfGroup timestamp adjustment logic pkg/solver/loracloud/loracloud.go	Detects EndOfGroup from decoded GNSS‑NG header and increments uplinkMsg.Timestamp by 1 second when non‑nil before constructing/sending the HTTP request.
Test coverage and helper utilities pkg/solver/loracloud/loracloud_test.go	Adds encoding/json import and float64Ptr helper; two tests verify (+1s) adjustment on EndOfGroup and that the caller's timestamp pointer is not mutated.
Secrets baseline maintenance .secrets.baseline	Updates line_number entries for two Hex High Entropy String findings in pkg/solver/loracloud/loracloud_test.go and refreshes generated_at to the new timestamp.`

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant DeliverUplinkMessage
  participant GNSSNGDecoder
  participant LoraCloudEndpoint
  Caller->>DeliverUplinkMessage: Deliver uplink message (with Timestamp)
  DeliverUplinkMessage->>GNSSNGDecoder: decode GNSS-NG header
  GNSSNGDecoder-->>DeliverUplinkMessage: header (EndOfGroup=true)
  DeliverUplinkMessage->>DeliverUplinkMessage: if EndOfGroup && Timestamp != nil: Timestamp += 1s
  DeliverUplinkMessage->>LoraCloudEndpoint: HTTP POST with adjusted Timestamp
  LoraCloudEndpoint-->>DeliverUplinkMessage: 200 OK

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• JanickFischer

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: a timestamp adjustment for GNSS-NG End-of-Group uplinks in the LoRaCloud solver.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/loracloud-eog-timestamp-bump

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR adjusts LoRaCloud uplink delivery so GNSS-NG End-of-Group messages with a request timestamp are sent 1 second later, ensuring they sort after prior captures in the same group without mutating the caller’s timestamp pointer.

Changes:

• Adds local timestamp adjustment for EoG uplinks before marshaling the LoRaCloud request.
• Adds tests for EoG timestamp bumping, nil timestamp behavior, non-EoG behavior, and caller pointer immutability.
• Updates the secrets baseline line numbers after test file changes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
pkg/solver/loracloud/loracloud.go	Adds EoG timestamp adjustment before sending uplink requests.
pkg/solver/loracloud/loracloud_test.go	Adds regression coverage for timestamp adjustment behavior.
.secrets.baseline	Refreshes baseline metadata/line numbers for shifted test content.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 0