Skip to content

Conversation

@github-actions
Copy link
Contributor

This is an automated pull request to merge tofik/enhance-vendor-risk-assestment into dev.
It was created by the [Auto Pull Request] action.

@vercel
Copy link

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
app Ready Ready Preview, Comment Dec 24, 2025 3:05pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
portal Skipped Skipped Dec 24, 2025 3:05pm

@cursor
Copy link

cursor bot commented Dec 24, 2025

PR Summary

Vendor Risk Assessment flow and UI

  • Backend now dedupes by reusing an existing task unless it’s still in_progress, creates an immediate placeholder in_progress task with structured description, then updates it to todo with research results; preserves creator/assignee on reuse and adjusts logging/return fields.
  • Frontend renders in_progress vendor risk assessment tasks as a non-interactive skeleton row and polls every 3s until completion.

Stability and data hygiene

  • Sanitize vendor websites before triggering batch assessments (ensure protocol, validate URL; only send if valid).
  • Fix unstable React list keys across vendor risk assessment cards (certifications, timeline, links) to prevent key collisions.

Written by Cursor Bugbot for commit e16542d. This will update automatically on new commits. Configure here.

@graphite-app graphite-app bot requested a review from Marfuen December 24, 2025 15:04
@graphite-app
Copy link

graphite-app bot commented Dec 24, 2025

Graphite Automations

"Auto-assign PRs to Author" took an action on this PR • (12/24/25)

1 reviewer was added to this PR based on Mariano Fuentes's automation.

@tofikwest tofikwest merged commit 012cba9 into main Dec 24, 2025
11 of 13 checks passed
@tofikwest tofikwest deleted the tofik/enhance-vendor-risk-assestment branch December 24, 2025 15:06
taskItem.status === 'in_progress' && isVendorRiskAssessmentTaskItem(taskItem);
if (isGeneratingVendorRiskAssessment) {
return <VendorRiskAssessmentTaskItemSkeletonRow />;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early return before hooks violates React Rules

The conditional early return at lines 129-131 occurs before the useState hooks are called. This violates React's Rules of Hooks, which require hooks to be called in the same order on every render. When a task is generating (in_progress status), the skeleton is returned without calling hooks. When generation completes and status changes, hooks will suddenly be called, causing React to throw a "Rendered more hooks than during the previous render" error. The polling mechanism in TaskItems.tsx will trigger this crash when the task finishes.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants