Skip to content

[INF-7570] startupProbe support for workflows-backend + agent-sandbox-controller - #366

Open
lukefoster11 wants to merge 1 commit into
mainfrom
more-startup-probes
Open

[INF-7570] startupProbe support for workflows-backend + agent-sandbox-controller#366
lukefoster11 wants to merge 1 commit into
mainfrom
more-startup-probes

Conversation

@lukefoster11

Copy link
Copy Markdown
Contributor

Add startup probe support in the chart for workflow-backend and agent-sandbox-controller.

@lukefoster11
lukefoster11 marked this pull request as ready for review August 24, 2026 23:00
@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge; both startup probes are opt-in and align with the existing health contracts of their respective workloads.

The new values remain disabled by default, the templates target the same endpoints and ports already used by existing probes, both public values files remain synchronized, and CI scenarios exercise the enabled branches.

Important Files Changed

Filename Overview
charts/retool/templates/deployment_workflows.yaml Adds a conditional workflow-backend startup probe consistent with that container’s existing liveness and readiness probe contract.
charts/retool/templates/deployment_agent_sandbox.yaml Adds a conditional controller startup probe using the controller’s existing /livez endpoint and named HTTP port.
charts/retool/values.yaml Defines disabled-by-default startup-probe settings for both affected workloads.
values.yaml Keeps the customer-facing values copy synchronized with the chart defaults.
charts/retool/ci/test-workflows-startup-probe-option.yaml Exercises rendering of the workflow-backend startup-probe branch.
charts/retool/ci/test-agent-sandbox-enabled-option.yaml Extends the broad agent-sandbox scenario to exercise the controller startup probe.

Reviews (1): Last reviewed commit: "workflow-backend + agent-sandbox-control..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants