Skip to content

Ensure pcb panels cut out pcb boards #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
seveibar wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Ensure pcb panels cut out pcb boards #567

seveibar wants to merge 1 commit into from

Conversation

@seveibar
Copy link
Contributor

@seveibar seveibar commented Nov 11, 2025

Summary

  • add a reusable helper for generating pcb_board solids that match their cutout footprint
  • subtract the combined pcb_board geometry from each pcb_panel in both the simplified and detailed builders
  • extend simplified board geometry tests to cover cutout volumes for single and multiple boards

Testing

  • bunx tsc --noEmit
  • bun test tests/create-simplified-board-geom.test.ts

Codex Task

@vercel
Copy link

vercel bot commented Nov 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
3d-viewer Ready Ready Preview Comment Nov 11, 2025 11:59pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShiboSoftwareDev ShiboSoftwareDev Awaiting requested review from ShiboSoftwareDev ShiboSoftwareDev will be requested when the pull request is marked ready for review ShiboSoftwareDev is a code owner

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seveibar