Add solder mask margin support for smtpads #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techmannih
requested review from
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
requested changes
Nov 30, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
there is a crazy amount of anycasting here, and hundreds of lines added to a file. Split up that file. Do not any cast
Contributor
|
the result and the fixture itself are good 
|
Contributor
|
you should clarify how you're going to split up the file before doing it. This file should be horizontally split, meaning you want to take a discriminated enum and use it to break up the file consistently e.g. if the file has lots of lines because of the different smtpad shapes, do one smtpad shape per file |
techmannih
commented
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pcb-viewer-git-fork-techmannih-marg2-tscircuit.vercel.app/?fixture=%7B%22path%22%3A%22src%2Fexamples%2Fsoldermask-margin-smtpad.fixture.tsx%22%7D