Skip to content

UX/perf: lazy-load spice plot and touch fixes #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
fluffyrabbot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

UX/perf: lazy-load spice plot and touch fixes #148

fluffyrabbot wants to merge 4 commits into from

Conversation

@fluffyrabbot
Copy link

@fluffyrabbot fluffyrabbot commented Dec 8, 2025 •
edited
Loading

Summary

  • Lazy-load the SPICE plot with Suspense fallback to defer heavy chart code until the overlay opens, keeping initial render lighter.
  • Align SPICE overlay layering and touch behavior: use zIndex map and touchAction none on the backdrop to avoid background scroll while the modal is open.
  • Throttle global pointer tracking in MouseTracker to reduce hover churn.
  • Realign fixtures: move reset/rerender controls to the left in examples 4/5/7 to avoid overlap, and shift the view menu icon/menu left so it no longer sits over the scrollbar.
  • Preserve mobile view menu touch UX (branch already had the touch fix); clean an unused import.

Test Plan

  • bun run build
  • Cosmos: open SPICE overlay (confirm fallback then plot), open view menu on touch and mouse; verify no interaction regressions.
  • Examples 4/5/7: verify controls no longer overlap with menus/scrollbar.

fluffyrabbot added 4 commits December 7, 2025 16:59
fix: enable mobile touch interactions for view menu
d30fef9 
Add stopPropagation() to prevent touch events from bubbling to parent
container handlers that were intercepting the events.

Add touchAction: manipulation CSS to ensure consistent touch behavior
across mobile browsers (especially iOS Safari).

Applied to:
- ViewMenuIcon (hamburger button)
- ViewMenu backdrop (close on tap outside)
- ViewMenu toggle option

Fixes tscircuit#108
fix: align spice overlay z-index and touch handling
97a23c8
perf: lazy-load spice plot overlay
79e2fbd
chore: remove unused BaseManualEditEvent import
42db654
@vercel
Copy link

vercel bot commented Dec 8, 2025

Someone is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fluffyrabbot