fix: return true for supportsResources on commandLineTool, macro, and xpc #454
+61
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… xpc Command line tools, macros, and XPC services can have resources embedded directly. When supportsResources returned false for these product types, Tuist's ResourcesProjectMapper would try to create a separate bundle target for them, which fails because these products cannot depend on bundles. This change makes supportsResources return true for commandLineTool, macro, and xpc, so resources are added directly to these targets instead of creating an invalid bundle dependency.
dosubot
bot
added
the
size:M
|
Related Documentation Checked 1 published document(s) in 0 knowledge base(s). No updates required. How did I do? Any feedback? |
fortmarek
approved these changes
Jan 14, 2026
pepicrft
requested review from
a team and
cschmatzler
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Command line tools, macros, and XPC services can have resources embedded directly. When
supportsResourcesreturnedfalsefor these product types, Tuist'sResourcesProjectMapperwould try to create a separate bundle target for them, which fails because these products cannot depend on bundles.This change makes
supportsResourcesreturntrueforcommandLineTool,macro, andxpc, so resources are added directly to these targets instead of creating an invalid bundle dependency.Context
After the recent change to restore static framework resources (tuist/tuist#9081), CI started failing with errors like:
The root cause was a mismatch between
PackageInfo.Target.TargetType.supportsResources(which returnstruefor SwiftPM executable targets) andXcodeGraph.Target.supportsResources(which was returningfalseforcommandLineTool).