Conversation
Lakoja
force-pushed
the
show-notifications-as-popup
branch
from
4a7349f to
2caeede
Compare
|
This will 100% bring us complaints. Please let us ask users first. |
What would the problems and complaints be? |
|
People who think popup is too introduing and have to go to settings and turn it off per channel. Just a simple question: |
Wouldn't that be equally true for audible notifications? Too intruding and must be configured for 9 channels? |
|
|
||
| private fun joinNames(notifications1: List<StatusBarNotification>, notifications2: List<Notification>): String? { | ||
| val names = java.util.ArrayList<String>(notifications1.size + notifications2.size) | ||
| val names1 = notifications1.map { it.notification.extras.getString(EXTRA_ACCOUNT_NAME) } |
There was a problem hiding this comment.
Use mapNotNull here and save the filterNotNull() below
|
Actually we should probably just merge this and see what users think. |
…ng them as group should still only make one sound) Also: Several name combination fixes
Lakoja
force-pushed
the
show-notifications-as-popup
branch
from
b4452a3 to
d1832fd
Compare
2 participants
No migration provided. As it makes no sense to delete existing notifications channels for this small change.