Build for limited API only on supported interpreters #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the limited API options only when building for non-free-threading CPython versions. Passing the flags on other interpreters (such as PyPy or GraalPy) or free-threading CPython versions results in build failures due to the limited API not being supported. While this package doesn't support free-threading Python right now, I think it makes sense to make the condition future-proof while I'm already fixing PyPy builds. See also cython/cython#7279 Signed-off-by: Michał Górny <[email protected]>
Member
|
Hi Michał . Thanks for the PR. I have enabled free-threading GHA builds to check the changes. |
Contributor
Author
|
Oh, sorry, I've missed the I think this may also fix pp311 build. |
Signed-off-by: Michał Górny <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Contributor
Author
|
All green now :-). |
Member
|
Thanks for the fix :) Let me know if you need a new release soon. |
Contributor
Author
|
I suppose it depends on how "soon" that is. I suppose we can stay on the old version for the time being, but would appreciate a new one in case Twisted were to start requiring the new version. |
Member
|
I will merge and look to trigger a new release. Twisted will require soon a new version of this test helper, as part of the work to support Python 3.14 |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the limited API options only when building for non-free-threading CPython versions. Passing the flags on other interpreters (such as PyPy or GraalPy) or free-threading CPython versions results in build failures due to the limited API not being supported.
While this package doesn't support free-threading Python right now, I think it makes sense to make the condition future-proof while I'm already fixing PyPy builds.
See also cython/cython#7279