fix: shut down tracer provider on CLI exit - #1205
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change retains the OpenTelemetry SDK tracer provider and adds explicit tracing shutdown after command execution. Shutdown errors are reported to stderr while preserving the command result. ChangesTracing lifecycle
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: 🟡 Moderate · up to The CLI now flushes and shuts down tracing after each command, including error exits, but the required workspace-wide clippy, build, and test checks are not listed as completed, so merge readiness remains moderate until those checks pass. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Closes #893.
Validation
cargo check -p dolos --bin doloscargo test -p dolos --bin dolos(26 passed, 1 ignored)cargo fmt --all -- --checkgit diff --checkSummary by CodeRabbit