Add support in getTextChangeMutation() for removed text nodes #138
Open
taylorhadden wants to merge 1 commit intotypewriter-editor:mainfrom
Open
Add support in getTextChangeMutation() for removed text nodes #138taylorhadden wants to merge 1 commit intotypewriter-editor:mainfrom
taylorhadden wants to merge 1 commit intotypewriter-editor:mainfrom
Conversation
…e deleted text nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two common cases where mutation parsing gives up and falls back to a whole-document diff:
<br>.In both cases,
getChangedLineRange()doesn't resolve to a correct range as it early-outs on the deleted text element. This results in diffing the entire document.getTextChangeMutation()already handled replacing a<br>with text, so I modified it to also handle the reverse. I also added the handling of a removed text node that had a previous sibling. Pulling theindexresolution into the function allowed these slightly different situations to be handled appropriately.If you feel this change modifies
getTextChangeMutation()too much, I can instead look to improvegetChangedLinkRange()so that these situations fall back to a line diff instead of a whole-document diff.