-
Notifications
You must be signed in to change notification settings - Fork 832
Adding invert method to ordinal scale #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mcnuttandrew
merged 14 commits into
uber:master
from
bognikol:add_invert_to_ordinal_scale
Nov 27, 2018
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
353b98a
Adding workaround-implementation of 'invert' method for d3-scale ordi…
bognikol 2077f18
Adding temp dist for my fork.
bognikol ff29ca4
Merge remote-tracking branch 'upstream/master'
bognikol 91c5259
Merge remote-tracking branch 'upstream/master'
bognikol b339e7d
Merge branch 'master' of https://github.com/bognikol/react-vis
bognikol 60071ca
Fixing linting errors.
bognikol d0906d4
Adding forgotten file.
bognikol 9bf6279
Adding tests for invert functionality of ordinal scale.
bognikol a599309
Merge branch 'master' of https://github.com/bognikol/react-vis
bognikol aa5c740
Revert "Adding temp dist for my fork."
bognikol f34a9c1
Revert "Revert "Adding temp dist for my fork.""
bognikol b187601
Removing redundant temp dist.
bognikol 7f888ed
Improving addInvertFunctionToOrdinalScaleObject function.
bognikol 21696f6
Updating style in addInvertFunctionToOrdinalScaleObject function
bognikol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a test for this that also capture padding? or does this do that already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are already testing padding of 0.5 (which is padding we use in react-vis).
This is so-called 'outer' padding (padding before first bar and after last bar).
Inner padding is set to 1.0 in d3-scale, as we are really using 'point-scale' from d3-scale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌