Repository navigation
Conversation
Author
|
Could a maintainer approve the workflows for |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix installed macOS command-line tools failing to load
@rpath/libopenjp2.7.dylibafter relocation. Closes #1622.For shared-library builds on macOS, append an executable-relative install RPATH to
opj_compress,opj_decompress, andopj_dump. Derive it from the configured GNU install directories and retain any existingCMAKE_INSTALL_RPATH. Static builds and other platforms are unchanged.Validation
On native macOS ARM64, the unmodified installed
opj_decompress -haborted after relocation withLibrary not loaded: @rpath/libopenjp2.7.dylibandno LC_RPATH's found.After the change, CPack ZIPs extracted with the native archive utility into paths containing spaces passed six CLI launch checks, with all
DYLD_*environment variables removed:bin/lib: all three tools printed their help, using@loader_path/../lib.tools/bin/lib64: all three tools printed their help, using@loader_path/../../lib64; a supplied@loader_path/existingRPATH was retained.Each tool's help path returned its expected status 1. The original compiled binaries were reused: both subsequent Ninja builds reported no work to do. Optional PNG, TIFF, LCMS2, and ZLIB package discovery was disabled for the focused local build. The diff check passed. No codec conformance corpus, numerical validation, full test suite, or Intel-host runtime check was performed. Hosted CI is separate from these local results.