Skip to content

Conversation

@sunillshastry
Copy link

  • Updated ComboBox.module.css file with the .input class to have a background-color: inherit property.

This ensures that the <input> background is accordingly updated on light and dark mode.

…undColor' value - this ensures the correct background color for the input in light/dark mode(s)
@vercel
Copy link

vercel bot commented Oct 22, 2025

@sunillshastry is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

@joshcancode
Copy link

The background-color should be transparent and not inherit to be consistent with Input elements in different components, correct?

@sunillshastry
Copy link
Author

The background-color should be transparent and not inherit to be consistent with Input elements in different components, correct?

In my opinion, the inherit option provides a better use case. Should the user manually have a specific background-color property for any parent or the Input component itself, it will be better suited to inherit the parent's background colour value. Essentially, the difference is negligible if you ask me.

1 similar comment
@sunillshastry
Copy link
Author

The background-color should be transparent and not inherit to be consistent with Input elements in different components, correct?

In my opinion, the inherit option provides a better use case. Should the user manually have a specific background-color property for any parent or the Input component itself, it will be better suited to inherit the parent's background colour value. Essentially, the difference is negligible if you ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants