Skip to content

Step 5: Error-driven retry #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pwerry wants to merge 1 commit into
base: step-4-validation
Choose a base branch
from
Open

Step 5: Error-driven retry #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 43 additions & 13 deletions src/engine/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import { synthesize } from "../synthesis/synthesize.js";
import { validatePlan } from "../validation/validate.js";
import { executePlan } from "./execute.js";
import { toolResultMessage, type LlmMessage } from "../llm/provider.js";

/** A synthesized query plan: which collection to run against, and the aggregation pipeline. */
export interface QueryPlan {
Expand Down Expand Up @@ -36,30 +37,59 @@ export interface RunOptions {

/**
* Turn a natural-language question into a MongoDB query, run it, return the outcome.
* Step 4: synthesize -> validate -> execute. (The retry loop comes in step 5.)
* Step 5: synthesize -> validate -> execute, feeding validation/runtime errors back
* to the model so it self-corrects, up to maxAttempts. The trace records every
* attempt (plan + why it was rejected) so the UI can show the self-correction.
*/
export async function runQuery(query: string, opts: RunOptions = {}): Promise<Outcome> {
const maxAttempts = opts.maxAttempts ?? 3;
const trace: Attempt[] = [];

let plan: QueryPlan;
let toolUseId: string;
let messages: LlmMessage[];
try {
({ plan } = await synthesize(query, { names: opts.names }));
({ plan, toolUseId, messages } = await synthesize(query, { names: opts.names }));
} catch (err) {
return { type: "ResolutionFailed", reason: errorText(err), attempts: 1 };
}

opts.onPlan?.(plan, 1);
for (let attempt = 1; attempt <= maxAttempts; attempt++) {
opts.onPlan?.(plan, attempt);

let errors: string[] | null = null;
const validation = await validatePlan(plan);
if (!validation.ok) {
errors = validation.errors;
} else {
try {
const rows = await executePlan(plan);
trace.push({ plan, errors: [] });
return rows.length
? { type: "Success", rows, plan, attempts: attempt, trace }
: { type: "NoResults", plan, attempts: attempt, trace };
} catch (err) {
errors = [errorText(err)];
}
}

trace.push({ plan, errors });

if (attempt === maxAttempts) {
return { type: "MaxAttemptsExceeded", errors, plan, attempts: attempt, trace };
}

// The trace records each attempt (plan + why it was rejected) so the UI can show
// the validation outcome. Step 4 has a single attempt; step 5 appends per retry.
const validation = await validatePlan(plan);
const trace: Attempt[] = [{ plan, errors: validation.ok ? [] : validation.errors }];
if (!validation.ok) {
return { type: "MaxAttemptsExceeded", errors: validation.errors, plan, attempts: 1, trace };
// Feed the error back as a tool result and let the model correct itself.
const feedback = `Query rejected:\n- ${errors.join("\n- ")}\nFix the pipeline and call the tool again.`;
messages = [...messages, toolResultMessage(toolUseId, feedback, true)];
try {
({ plan, toolUseId, messages } = await synthesize(query, { history: messages }));
} catch (err) {
return { type: "ResolutionFailed", reason: errorText(err), attempts: attempt + 1 };
}
}

const rows = await executePlan(plan);
return rows.length
? { type: "Success", rows, plan, attempts: 1, trace }
: { type: "NoResults", plan, attempts: 1, trace };
return { type: "ResolutionFailed", reason: "exhausted attempts", attempts: maxAttempts };
}

function errorText(err: unknown): string {
Expand Down