Skip to content

[UNDERTOW-1901] - fix max entity handling for multipart #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
baranowb merged 1 commit into from
Jul 29, 2024
Merged

[UNDERTOW-1901] - fix max entity handling for multipart #1082

baranowb merged 1 commit into from
Jul 29, 2024

Conversation

@baranowb
Copy link
Contributor

@baranowb baranowb commented Apr 6, 2021 •
edited by fl4via
Loading

@baranowb baranowb mentioned this pull request Apr 6, 2021
Closed
@fl4via fl4via added bug fix Contains bug fix(es) next release This PR will be merged before next release or has already been merged (for payload double check) labels Apr 8, 2021
@msfm
Copy link
Contributor

msfm commented Apr 8, 2021 •
edited
Loading

isMultiPartExchange() should be moved from HttpServerExchange to ServletInitialHandler like PR#1083 and PR#1084.

@ropalka ropalka added the waiting PR update Awaiting PR update(s) from contributor before merging label Apr 13, 2021
@baranowb
Copy link
Contributor Author

baranowb commented May 4, 2021

isMultiPartExchange() should be moved from HttpServerExchange to ServletInitialHandler like PR#1083 and PR#1084.

This has been declined. Reason for this is that other two PRs have it as private method as those are maintenance. This method is actually on purpose in HSE, since its related to exchange.
@ropalka ^^

fl4via
fl4via requested changes Jun 17, 2021
View reviewed changes
Copy link
Member

@fl4via fl4via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baranowb Can you please split this fix into two parts? I'm adding a Jira and scheduling it for 2.3.x as this changes public class API, and for the time being, lets submit a copy of the 2.0.x fix to master.

@fl4via
Copy link
Member

fl4via commented Jun 17, 2021

@baranowb Alternatively, and even simpler, we can just change this PR Jira to UNDERTOW-1901, that one is assinged to Undertow 2.3.0.Final, and open a new one for UNDERTOW-1601 master that just cherry-picks the fix that was submitted for 2.0.x

@baranowb
Copy link
Contributor Author

baranowb commented Jun 17, 2021

@fl4via yeah, sure.

@baranowb baranowb changed the title [UNDERTOW-1601] - fix max entity handling for multipart [UNDERTOW-1901] - fix max entity handling for multipart Jun 18, 2021
@baranowb
Copy link
Contributor Author

baranowb commented Jun 18, 2021

TODO: update target branch once 2.3.x is up

@baranowb baranowb mentioned this pull request Jun 18, 2021
Merged
@baranowb baranowb force-pushed the UNDERTOW-1601_paddy_whack branch from 7df574c to 7183727 Compare June 18, 2021 06:08
@fl4via fl4via added new feature / API change New feature to be introduced or a change to the API (non suitable to minor releases) and removed next release This PR will be merged before next release or has already been merged (for payload double check) waiting PR update Awaiting PR update(s) from contributor before merging bug fix Contains bug fix(es) labels Jun 19, 2021
@baranowb baranowb force-pushed the UNDERTOW-1601_paddy_whack branch from 7183727 to ad9a6a2 Compare January 17, 2023 08:09
@baranowb baranowb requested a review from ropalka July 16, 2024 09:44
@baranowb baranowb added the waiting peer review PRs that edit core classes might require an extra review label Jul 16, 2024
@ropalka ropalka added next release This PR will be merged before next release or has already been merged (for payload double check) enhancement Enhances existing behaviour or code and removed waiting peer review PRs that edit core classes might require an extra review labels Jul 17, 2024
@baranowb baranowb merged commit ab73f9c into undertow-io:main Jul 29, 2024
@fl4via fl4via mentioned this pull request Oct 17, 2025
Merged
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ropalka ropalka ropalka approved these changes

@fl4via fl4via fl4via approved these changes

Assignees

No one assigned

Labels

enhancement Enhances existing behaviour or code new feature / API change New feature to be introduced or a change to the API (non suitable to minor releases)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@baranowb @msfm @fl4via @ropalka