[UNDERTOW-2249] At ClientConnection, use ClosedChannelException to no… #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
added
duplicate
fl4via
removed
under verification
…tify clientCallback instead of IOException complaining of invalid connection state. At HttpClientTestCase.testSslServerIdentity, enforce that the exception received is ClosedChannelException Signed-off-by: Flavia Rainone <[email protected]>
fl4via
added
next release
fl4via
added
the
new feature / API change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tify clientCallback instead of IOException complaining of invalid connection state. At HttpClientTestCase.testSslServerIdentity, enforce that the exception received is ClosedChannelException
Jira: https://issues.redhat.com/browse/UNDERTOW-2249
Altenative to PR #1454
Which option to be chosen is being discussed at Zulip: https://wildfly.zulipchat.com/#narrow/stream/174183-undertow/topic/Should.20ClientConnection.20request.20get.20IOException.20when.20closed.3F
Ported to 2.4.x by #1821