Skip to content

[UNDERTOW-2149] - cookie config paths fix on UNDERTOW-2082 #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
baranowb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2149] - cookie config paths fix on UNDERTOW-2082 #1470

baranowb wants to merge 1 commit into from

Conversation

@baranowb
Copy link
Contributor

@baranowb baranowb commented Apr 18, 2023

@fl4via fl4via added under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting peer review PRs that edit core classes might require an extra review labels Apr 23, 2023
@fl4via
Copy link
Member

fl4via commented Apr 23, 2023

Please, do not merge this. There is a requirement for reviewing this under the light of "a possible problem/bug - requestPath vs resolvedPath vs servletPath".
Hence the Under verification.
Scheduled for being fully reviewed/merged on May 2nd, upon my return from PTO.

@fl4via fl4via added the bug fix Contains bug fix(es) label Apr 23, 2023
ropalka
ropalka approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ropalka ropalka removed the waiting peer review PRs that edit core classes might require an extra review label Jul 28, 2023
@baranowb baranowb added next release This PR will be merged before next release or has already been merged (for payload double check) under verification Currently being verified (running tests, reviewing) before posting a review to contributor and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor next release This PR will be merged before next release or has already been merged (for payload double check) labels Jul 29, 2024
@baranowb baranowb added next release This PR will be merged before next release or has already been merged (for payload double check) and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor labels Oct 21, 2024
@baranowb
Copy link
Contributor Author

baranowb commented Oct 21, 2024

"next release" based on reviews.

@baranowb baranowb added on hold PR awaits non CI/Review holdover and removed next release This PR will be merged before next release or has already been merged (for payload double check) labels Nov 26, 2024
@fl4via fl4via added under verification Currently being verified (running tests, reviewing) before posting a review to contributor and removed on hold PR awaits non CI/Review holdover under verification Currently being verified (running tests, reviewing) before posting a review to contributor labels Oct 17, 2025
@fl4via fl4via added waiting CI check Ready to be merged but waiting for CI check failed CI Introduced new regession(s) during CI check and removed waiting CI check Ready to be merged but waiting for CI check labels Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ropalka ropalka ropalka approved these changes

@fl4via fl4via fl4via approved these changes

Assignees

No one assigned

Labels

bug fix Contains bug fix(es) failed CI Introduced new regession(s) during CI check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baranowb @fl4via @ropalka