Tld generator removed - dep update fixes#455
Open
Collingr wants to merge 2 commits intounic:developfrom
Open
Conversation
Google tld is abandonware. it is not java 11+ compatible.
dependabot moved org.apache.felix:org.apache.felix.webconsole from 4.2.2 to 4.9.10 There are functional changes to the api the were not covered. AbstractWebConsolePlugin now expects a RequestVariableResolver on the request before rendering HTML. Old behavior (4.2.2): startResponse() could run without a resolver. It either used a default or skipped variable resolution when the attribute was missing. New behavior (4.9.10): startResponse() calls r.put(...) on the resolver. If the attribute is missing, r is null and you get a NullPointerException. This is only used in the tests, so the test has been updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Im going to attempt to get this to java21 for LTS.
to get here I'm dropping tld-generator as its dead weight, project is abandoned by google and will not get 21 support.
Fixes the haphazard dependabot updates that broke tests.