-
Notifications
You must be signed in to change notification settings - Fork 0
Sharding improvements #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lploom
approved these changes
Nov 20, 2025
Contributor
lploom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MastaP
approved these changes
Nov 28, 2025
- Parent round retry on BFT failures - Performance test with SHARD_TARGETS and configurable params
errors and let recovery handle on restart.
…, updated signatures
Add crash recovery for block finalization
Contributor
|
Tested locally using GO aggregator commit b271ce2.
4. Also checked that after droping mongoDB container related to specific sharding node, then this node would crash and when mongoDb container would be UI it would be able to establish connection to it (tested in sharding mode without HA).
5. ALso I was able to sucessfuly add sharding config to subscription sevice
And I was able to send successfully commitments through subscription service.
Merging and moving task to done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





finalizedflag to blocks and add recovery mechanism on startup (retry storing commitments to DB and finalize the block)