Skip to content

Resolve some properties outside the loop in UnicodeUtilities.java - #1606

Open
roozbehp wants to merge 1 commit into
mainfrom
roozbehp-reuse-props
Open

roozbehp wants to merge 1 commit into
mainfrom
roozbehp-reuse-props

Conversation

@roozbehp

Copy link
Copy Markdown
Contributor

Also:

  • Resolve development properties only if showDevProperties is true
  • Check allowRetroactive before calling property.isTrivial() in VersionedProperty.java

This further improves the speed of list-unicodeset.jsp resolution for [:L:] by 4x on top of #1605. Without #1605 applied, it improves the speed of the above resolution by 6x.

It also reduces temporary memory allocations by about 80%-90%.

  • Approver: Feel free to merge on my behalf
    • rebase & merge one or more commits
    • squash & merge multiple commits into one

Also:
- Resolve development properties only if showDevProperties is true
- Check allowRetroactive before calling property.isTrivial() in
  VersionedProperty.java

This further improves the speed of list-unicodeset.jsp resolution for [:L:]
by 4x on top of #1605.
Without #1605 applied, it
improves the speed of the above resolution by 6x.

It also reduces temporary memory allocations by about 90%.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant